Re: [PATCH 2/2] hwmon: (coretemp) fix coding style issues

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] A blank line was incorrectly added inside a contiguous block of declarations in `create_core_attrs()`, splitting the variable declarations.
--

commit fd6a696ecbdee696c6e67fb77fb06e3c1baa31cc
Author: Roman Bakshansky <bakshansky.lists@gmail.com>

hwmon: (coretemp) fix coding style issues

This commit addresses several coding style warnings reported by checkpatch.pl.
It updates header inclusions, adds missing blank lines, combines split strings,
and reorders the __initconst attribute.

> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index c722b1d8e4804..a79c2d65a2bee 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
[ ... ]
> @@ -424,6 +423,7 @@ static ssize_t show_temp(struct device *dev,
>  static int create_core_attrs(struct temp_data *tdata, struct device *dev)
>  {
>  	int i;
> +

This isn't a bug, but does this newly added blank line split a contiguous
block of variable declarations?

The static array rd_ptr is also a variable declaration, so this separates it
from the int i declaration. It looks like checkpatch.pl might have misparsed
the complex function pointer array declaration as a statement.

>  	static ssize_t (*const rd_ptr[TOTAL_ATTRS]) (struct device *dev,
>  			struct device_attribute *devattr, char *buf) = {
>  			show_label, show_crit_alarm, show_temp, show_tjmax,
>  			show_ttarget };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260516114253.5466-1-bakshansky.lists@gmail.com?part=2