Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: Chen-Shi-Hong <eric039eric@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] Documentation: hwmon: lm75: document sysfs interface
Date: Sat, 16 May 2026 16:14:39 +0000	[thread overview]
Message-ID: <20260516161440.3A457C19425@smtp.kernel.org> (raw)
In-Reply-To: <20260516161037.1486-1-eric039eric@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added sysfs-Interface documentation omits the `temp1_label` attribute.
--

commit 9ea544e30685306c26501a73ae7941baf5244e12
Author: Chen-Shi-Hong <eric039eric@gmail.com>

Documentation: hwmon: lm75: document sysfs interface

This commit adds a new sysfs-Interface section to the lm75 driver
documentation to describe the supported sysfs attributes.

> diff --git a/Documentation/hwmon/lm75.rst b/Documentation/hwmon/lm75.rst
> index 4269da04508ef..cbf737948c1d8 100644
> --- a/Documentation/hwmon/lm75.rst
> +++ b/Documentation/hwmon/lm75.rst
> @@ -181,3 +181,21 @@ is supported by this driver, other specific enhancements are not.
>  
>  The LM77 is not supported, contrary to what we pretended for a long time.
>  Both chips are simply not compatible, value encoding differs.
> +
> +sysfs-Interface
> +---------------
> +
> +================ ============================================
> +temp1_input      temperature input
> +temp1_max        maximum temperature
> +temp1_max_hyst   maximum temperature hysteresis
> +================ ============================================

Should this section also document the temp1_label attribute?

Looking at drivers/hwmon/lm75.c, the driver exposes the temp1_label
attribute via HWMON_T_LABEL if a label device property is present.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260516161037.1486-1-eric039eric@gmail.com?part=1

      reply	other threads:[~2026-05-16 16:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-16 16:10 [PATCH] Documentation: hwmon: lm75: document sysfs interface Chen-Shi-Hong
2026-05-16 16:14 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260516161440.3A457C19425@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=eric039eric@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox