Re: [PATCH v2 1/2] hwmon: (lenovo-ec-sensors): Convert to devm_request_region()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message inaccurately claims to remove five `release_region()` calls and drop unnecessary braces, but only four calls were removed and the braces were left intact.
--

commit e8c1e48be4d237988380d2577325024d4865618f
Author: Kean Ren <rh_king@163.com>

hwmon: (lenovo-ec-sensors): Convert to devm_request_region()

This commit replaces manual request_region() and release_region() calls
with devm_request_region() to allow the device-managed framework to
handle the I/O region lifetime automatically.

> Remove all five manual release_region() calls that are now handled
> automatically, and drop the unnecessary braces on the single-statement
> blocks that previously contained them.

[Severity: Medium]
Is this description accurate? The patch diff shows that only four
release_region() calls were removed.

> diff --git a/drivers/hwmon/lenovo-ec-sensors.c b/drivers/hwmon/lenovo-ec-sensors.c
> index 8681bbf6665b1..45db49e189d3d 100644
> --- a/drivers/hwmon/lenovo-ec-sensors.c
> +++ b/drivers/hwmon/lenovo-ec-sensors.c
> @@ -541,7 +541,6 @@ static int lenovo_ec_probe(struct platform_device *pdev)
>  	    (inb_p(MCHP_EMI0_EC_DATA_BYTE1) != 'C') &&
>  	    (inb_p(MCHP_EMI0_EC_DATA_BYTE2) != 'H') &&
>  	    (inb_p(MCHP_EMI0_EC_DATA_BYTE3) != 'P')) {
> -		release_region(IO_REGION_START, IO_REGION_LENGTH);
>  		return -ENODEV;
>  	}

[Severity: Medium]
This isn't a bug, but could these curly braces be removed? The commit
message mentions dropping the unnecessary braces on the single-statement
blocks, but they appear to have been left intact here.

[ ... ]

> @@ -607,7 +605,6 @@ static int __init lenovo_ec_init(void)
>  				       lenovo_ec_probe, NULL, 0, NULL, 0);
>  
>  	if (IS_ERR(lenovo_ec_sensors_platform_device)) {
> -		release_region(IO_REGION_START, IO_REGION_LENGTH);
>  		return PTR_ERR(lenovo_ec_sensors_platform_device);
>  	}

[Severity: Medium]
Could the braces be removed from this block as well, to match the
description in the commit message?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514011411.4167069-1-rh_king@163.com?part=1