Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: xiaopeitux@foxmail.com
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v3 1/4] hwmon: (gpd-fan): drop global driver data and use per-device allocation
Date: Mon, 08 Jun 2026 01:52:06 +0000	[thread overview]
Message-ID: <20260608015206.EFA641F00893@smtp.kernel.org> (raw)
In-Reply-To: <tencent_E4CE09DC1CB1AB4C0411F71B9507E4A49706@qq.com>

> From: Pei Xiao <xiaopei01@kylinos.cn>
> 
> replace the global state gpd_driver_priv with per-device private data
> (struct gpd_fan_data) allocated in probe. This allows the driver to
> support multiple instances in the future and aligns with kernel best
> practices.
> 
> No functional change intended.

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1780880972.git.xiaopei01@kylinos.cn?part=1


  reply	other threads:[~2026-06-08  1:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1780880972.git.xiaopei01@kylinos.cn>
2026-06-08  1:40 ` [PATCH v3 1/4] hwmon: (gpd-fan): drop global driver data and use per-device allocation xiaopeitux
2026-06-08  1:52   ` sashiko-bot [this message]
2026-06-09 13:04   ` Guenter Roeck
2026-06-10  1:30     ` Pei Xiao
2026-06-09 15:46   ` Cryolitia PukNgae
2026-06-10  1:36     ` Pei Xiao
2026-06-08  1:40 ` [PATCH v3 2/4] hwmon: (gpd-fan): Initialize EC before registering hwmon device xiaopeitux
2026-06-08  1:53   ` sashiko-bot
2026-06-08 13:01     ` Guenter Roeck
2026-06-08  1:40 ` [PATCH v3 3/4] hwmon: (gpd-fan): upgrade log level from warn to err for platform device creation failure xiaopeitux
2026-06-08  1:48   ` sashiko-bot
2026-06-08  1:40 ` [PATCH v3 4/4] hwmon: (gpd-fan): fix race condition between device removal and sysfs access xiaopeitux
2026-06-08  1:47   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260608015206.EFA641F00893@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=xiaopeitux@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox