From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F61B37AA65 for ; Mon, 8 Jun 2026 13:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780924408; cv=none; b=ZPEoPBExS4EQAx/7UwLGiZlFSnRZGUtP4umAE0CFSnYZAGclzAP1L5tB9Bfb97ko0f13ZEZOenD3378+z45SZWC37t8avjf+dDVlDWgFuehXQPtmiScKPD2Y2afc02YaYVFy2EWbFZ4Uvx+5n2QguBqU7DWastdzYrdcqIFbQLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780924408; c=relaxed/simple; bh=GKK8Ixi+GHOnr+qaJ7bvGg7XDQ1Hbn/SzQbnLfpXmhg=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=Asjvd9lAtRQ/0FI8HVKVojwzH45bu/Ae5MSsgCf3QAU2r15prt8wprzfd9nG2CuRQL9317rhbiqVwwgk4Dtn57DUzFNX6k9i5y4G/3tRzTO52K1l8pFyyATqTI10p35pB0BDL2BgYL+SkUaMBV7UezYr6C0wpUITv7QK41GHfds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YOVB1+AX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YOVB1+AX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 159171F00893; Mon, 8 Jun 2026 13:13:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780924407; bh=GKK8Ixi+GHOnr+qaJ7bvGg7XDQ1Hbn/SzQbnLfpXmhg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=YOVB1+AXSuxfcrvjsggrhDvRddn/vdutr7q5uJHA+M8MZZuPGwIBWY6PL/lVM3JgQ C6pyTYa6uXHEHq+hFdYg8M7Zvv8uzo6P3AYuL5PDnqmQDxGWCRoqTj1fnepPVsWpzK 4pz/u2XzkmLGOpy9fV4mTek3F9L6Z4lC1k1j2rMPb+CIFPnSsDlhLvPbpxlAtHxo3f N39icNXxImpPno2wIXaHxETMSX4bBHrgVGhsQMP9u8tlHMiVau8SzGOK9jueCwt/1R 5bpq+HECvgZz2LzgXfO9fENu51f9H5QdAIvxl6zgEWV972x49SpGKVTBLD9C9+BCRp fmvEYx4uMvhFw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 3/3] hwmon: ina238: add update_interval_us attribute Reply-To: sashiko-reviews@lists.linux.dev To: "Ferdinand Schwenk via B4 Relay" Cc: linux-hwmon@vger.kernel.org In-Reply-To: <20260608-hwmon-ina238-update-interval-us-v2-v2-3-2d939fbb2ea1@advastore.com> References: <20260608-hwmon-ina238-update-interval-us-v2-v2-3-2d939fbb2ea1@advastore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 08 Jun 2026 13:13:26 +0000 Message-Id: <20260608131327.159171F00893@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > From: Ferdinand Schwenk >=20 > The INA238 family supports eight conversion time steps from 50 us to > 4120 us (SQ52206: 66 us to 8230 us). At the millisecond granularity of > update_interval, the four shortest steps (50, 84, 150, 280 us) all > round to the same value and cannot be individually selected. >=20 > Add support for the generic update_interval_us attribute, which reports > and programs the same ADC cycle time as update_interval but in > microseconds, giving userspace full access to all conversion time steps. >=20 > Both attributes reflect the total cycle time including the active > averaging count: the reported value is the raw conversion time > multiplied by the number of averaged samples, and writes apply the > inverse mapping. Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260608-hwmon-ina2= 38-update-interval-us-v2-v2-0-2d939fbb2ea1@advastore.com?part=3D3