From: sashiko-bot@kernel.org
To: "Ferdinand Schwenk via B4 Relay"
<devnull+ferdinand.schwenk.advastore.com@kernel.org>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v3 3/3] hwmon: ina238: add update_interval_us attribute
Date: Tue, 09 Jun 2026 19:49:40 +0000 [thread overview]
Message-ID: <20260609194940.AAF851F00899@smtp.kernel.org> (raw)
In-Reply-To: <20260609-hwmon-ina238-update-interval-us-v2-v3-3-016b55567950@advastore.com>
> From: Ferdinand Schwenk <ferdinand.schwenk@advastore.com>
>
> The INA238 family supports eight conversion time steps from 50 us to
> 4120 us (SQ52206: 66 us to 8230 us). At the millisecond granularity of
> update_interval, the four shortest steps (50, 84, 150, 280 us) all
> round to the same value and cannot be individually selected.
>
> Add support for the generic update_interval_us attribute, which reports
> and programs the same ADC cycle time as update_interval but in
> microseconds, giving userspace full access to all conversion time steps.
>
> Both attributes reflect the total cycle time including the active
> averaging count: the reported value is the raw conversion time
> multiplied by the number of averaged samples, and writes apply the
> inverse mapping.
>
> Signed-off-by: Ferdinand Schwenk <ferdinand.schwenk@advastore.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260609-hwmon-ina238-update-interval-us-v2-v3-0-016b55567950@advastore.com?part=3
next prev parent reply other threads:[~2026-06-09 19:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 19:43 [PATCH v3 0/3] hwmon: ina238: add samples and update_interval_us support Ferdinand Schwenk via B4 Relay
2026-06-09 19:43 ` [PATCH v3 1/3] hwmon: ina238: add support for samples and update_interval Ferdinand Schwenk via B4 Relay
2026-06-09 19:50 ` sashiko-bot
2026-06-09 20:44 ` Guenter Roeck
2026-06-09 19:43 ` [PATCH v3 2/3] hwmon: Add update_interval_us chip attribute Ferdinand Schwenk via B4 Relay
2026-06-09 19:48 ` sashiko-bot
2026-06-09 20:45 ` Guenter Roeck
2026-06-09 19:43 ` [PATCH v3 3/3] hwmon: ina238: add update_interval_us attribute Ferdinand Schwenk via B4 Relay
2026-06-09 19:49 ` sashiko-bot [this message]
2026-06-09 20:49 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260609194940.AAF851F00899@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=devnull+ferdinand.schwenk.advastore.com@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox