From: sashiko-bot@kernel.org
To: "Pei Xiao" <xiaopei01@kylinos.cn>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v4 3/4] hwmon: (gpd-fan): upgrade log level from warn to err for platform device creation failure
Date: Wed, 10 Jun 2026 01:54:28 +0000 [thread overview]
Message-ID: <20260610015429.5FBEB1F00893@smtp.kernel.org> (raw)
In-Reply-To: <aeb2eaa6df90178b18057a8022a0eccde7bbc82c.1781055639.git.xiaopei01@kylinos.cn>
> When platform_create_bundle() fails, the error is fatal and prevents the
> driver from loading. Use pr_err() instead of pr_warn() to clearly indicate
> a critical failure.
>
> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1781055639.git.xiaopei01@kylinos.cn?part=3
next prev parent reply other threads:[~2026-06-10 1:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 1:49 [PATCH v4 0/4] some cleanup and fix in gpd-fan Pei Xiao
2026-06-10 1:49 ` [PATCH v4 1/4] hwmon: (gpd-fan): drop global driver data and use per-device allocation Pei Xiao
2026-06-10 2:02 ` sashiko-bot
2026-06-10 13:13 ` Guenter Roeck
2026-06-10 1:49 ` [PATCH v4 2/4] hwmon: (gpd-fan): Initialize EC before registering hwmon device Pei Xiao
2026-06-10 2:02 ` sashiko-bot
2026-06-10 13:13 ` Guenter Roeck
2026-06-10 1:49 ` [PATCH v4 3/4] hwmon: (gpd-fan): upgrade log level from warn to err for platform device creation failure Pei Xiao
2026-06-10 1:54 ` sashiko-bot [this message]
2026-06-10 13:14 ` Guenter Roeck
2026-06-10 1:49 ` [PATCH v4 4/4] hwmon: (gpd-fan): fix race condition between device removal and sysfs access Pei Xiao
2026-06-10 1:59 ` sashiko-bot
2026-06-10 13:15 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260610015429.5FBEB1F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=xiaopei01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox