From: sashiko-bot@kernel.org
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: tmp401: Read "ti,n-factor" as signed
Date: Fri, 12 Jun 2026 22:00:55 +0000 [thread overview]
Message-ID: <20260612220056.4E5671F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260612215332.1889497-1-robh@kernel.org>
> The "ti,n-factor" binding and examples allow negative correction
> values. Reading it as u32 makes the helper type disagree with the
> documented signed value and hides real schema mismatches.
>
> Use the signed helper so the DT access matches the s32 value stored by
> the driver.
>
> Assisted-by: Codex:gpt-5-5
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260612215332.1889497-1-robh@kernel.org?part=1
next prev parent reply other threads:[~2026-06-12 22:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 21:53 [PATCH] hwmon: tmp401: Read "ti,n-factor" as signed Rob Herring (Arm)
2026-06-12 22:00 ` sashiko-bot [this message]
2026-06-13 12:53 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260612220056.4E5671F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox