Re: [PATCH 1/7] dt-bindings: adm1275: ROHM BD12780 hot-swap controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Invalid use of the `items` object for the single-string compatible enum, allowing arrays of multiple arbitrary compatible strings.
--

commit 7132123aae357451c411a0cee036262cc9f62a45
Author: Matti Vaittinen <mazziesaccount@gmail.com>

dt-bindings: adm1275: ROHM BD12780 hot-swap controller

This commit adds support for the ROHM BD12780 and BD12780A hot-swap
controllers to the adm1275 device tree bindings. It introduces new
compatible strings, requiring BD12780A to use BD12780 as a fallback.

> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> index d6a7517f2a50c..bc67510ef3ab1 100644
> --- a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml

[ ... ]

> @@ -25,19 +25,35 @@ description: |
>  properties:
>    compatible:
> -    enum:
> -      - adi,adm1075
> -      - adi,adm1272
> -      - adi,adm1273
> -      - adi,adm1275
> -      - adi,adm1276
> -      - adi,adm1278
> -      - adi,adm1281
> -      - adi,adm1293
> -      - adi,adm1294
> -      - silergy,mc09c
> +    oneOf:
> +      - items:
> +          enum:
> +            - adi,adm1075
> +            - adi,adm1272
> +            - adi,adm1273

[Severity: Low]
Does wrapping this enum inside an items list inadvertently allow multiple
exclusive strings instead of restricting it to exactly one?

In dt-schema, applying an items object directly to a string-array property
like compatible defines the schema for all elements of the array, but does
not impose bounds on the array length. This might allow a device tree to
define a compatible property with multiple strings from this list, such as:
compatible = "adi,adm1075", "adi,adm1272";

To enforce exactly one string from the list, should the items wrapper be
removed so that the enum resides directly under oneOf?

> +            - adi,adm1275
> +            - adi,adm1276
> +            - adi,adm1278
> +            - adi,adm1281
> +            - adi,adm1293
> +            - adi,adm1294
> +            - rohm,bd12780
> +            - silergy,mc09c
> +
> +# Require BD12780 as a fall-back for BD12780A.
> +      - items:
> +          - const: rohm,bd12780a
> +          - const: rohm,bd12780

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1781591132.git.mazziesaccount@gmail.com?part=1