Re: [PATCH 2/3] dt-bindings: hwmon: pmbus: Support for onsemi's FD5121

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The binding lacks a `regulators` node definition, preventing it from functioning as a voltage regulator provider in devicetree.
- [Low] The devicetree example uses a specific model name for the node instead of a generic name.
--

commit 52162fef263cc41ea7598b089db89b70bb4f6ebb
Author: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>

dt-bindings: hwmon: pmbus: Support for onsemi's FD5121

This commit adds the devicetree schema for onsemi FD5121, FD5123, and FD5125
dual rail, multi-phase digital controllers.

> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/onnn,fd5121.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/onnn,fd5121.yaml
> new file mode 100644
> index 0000000000000..b0453b0634f0d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/onnn,fd5121.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false

[Severity: Medium]
Since this device is a multi-phase digital controller, should it have a
regulators subnode pattern?

The additionalProperties: false constraint strictly prohibits developers from
defining regulator constraints in their device trees. As the PMBus core
framework looks for the regulators child node, would it be better to add an
explicit pattern here to allow consumers to reference the device's voltage
rails?

> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      fd5121@50 {

[Severity: Low]
Is it possible to use a generic node name here like regulator@50, pmic@50, or
sensor@50 instead of the specific model name fd5121@50?

The Devicetree specification recommends generic node names to ensure standard
patterns are used in examples.

> +        compatible = "onnn,fd5121";
> +        reg = <0x50>;
> +      };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260622-support-fd5121-from-onsemi-v1-0-b31767689c65@onsemi.com?part=2