From: sashiko-bot@kernel.org
To: "Joshua Crofts" <joshua.crofts1@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 3/3] hwmon: (max6679) add missing 'select REGMAP_I2C' to Kconfig
Date: Mon, 29 Jun 2026 19:22:33 +0000 [thread overview]
Message-ID: <20260629192233.F169F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260629-add-kconfig-deps-v1-3-8104df929b1a@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message incorrectly references 'max6679' instead of 'max6697'.
--
commit 232f529a8bd06a5a57ba2d3974e729ff7df2ae67
Author: Joshua Crofts <joshua.crofts1@gmail.com>
hwmon: (max6679) add missing 'select REGMAP_I2C' to Kconfig
This commit adds a missing REGMAP_I2C selection to a Kconfig entry to prevent
potential build failures when regmap has not been previously selected.
> hwmon: (max6679) add missing 'select REGMAP_I2C' to Kconfig
>
> The Kconfig entry for the MAX6679 sensor doesn't contain a
> `select REGMAP_I2C` parameter, causing build failures if regmap
[Severity: Low]
This isn't a bug, but there appears to be a typo referencing max6679 and
MAX6679 in the commit subject and body. The code changes modify the entry for
SENSORS_MAX6697, and the Fixes tag also correctly notes max6697. Should the
commit message be updated to max6697 to accurately reflect the configuration it
modifies?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260629-add-kconfig-deps-v1-0-8104df929b1a@gmail.com?part=3
next prev parent reply other threads:[~2026-06-29 19:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 19:17 [PATCH 0/3] hwmon: (various) add missing `select REGMAP` to Kconfig Joshua Crofts
2026-06-29 19:17 ` [PATCH 1/3] hwmon: (max1619) add missing 'select REGMAP' " Joshua Crofts
2026-06-29 19:21 ` sashiko-bot
2026-06-29 20:35 ` Guenter Roeck
2026-06-29 19:17 ` [PATCH 2/3] hwmon: (ltc2992) add missing 'select REGMAP_I2C' " Joshua Crofts
2026-06-29 19:21 ` sashiko-bot
2026-06-29 20:36 ` Guenter Roeck
2026-06-29 19:17 ` [PATCH 3/3] hwmon: (max6679) " Joshua Crofts
2026-06-29 19:22 ` sashiko-bot [this message]
2026-06-29 19:26 ` Joshua Crofts
2026-06-29 20:39 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260629192233.F169F1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox