Re: [PATCH v6 1/3] dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal sensor provider support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added '#thermal-sensor-cells' property is missing from the 'required' list.
--

--- Patch [1]: [PATCH v6 1/3] dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal sensor provider support ---
commit 48ae118884c307667e25a720a62e87b8e32443c5
Author: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>

dt-bindings: embedded-controller: Add Lenovo ThinkPad T14s thermal sensor provider support

This commit documents the Lenovo ThinkPad T14s Embedded Controller as a
thermal sensor provider by adding the #thermal-sensor-cells property. This
allows the EC temperature sensors to be referenced from thermal zones.

> diff --git a/Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml
> --- a/Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml
> +++ b/Documentation/devicetree/bindings/embedded-controller/lenovo,thinkpad-t14s-ec.yaml
> @@ -26,6 +26,9 @@ properties:
>  
>    wakeup-source: true
>  
> +  "#thermal-sensor-cells":
> +    const: 1
> +
>  required:
>    - compatible
>    - reg

[Severity: Medium]
Should #thermal-sensor-cells be added to this required list?

When hardware gains new provider capabilities, omitting the corresponding
standard properties from the required list allows incomplete device tree
nodes to pass schema validation. Dependent thermal zones could fail at
runtime if they attempt to reference the embedded controller and the property
is missing.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707192228.14647-1-daniel.lezcano@oss.qualcomm.com?part=1