Re: [RFC PATCH] firmware: scmi: Make SCMI arch independent

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch fails to fully remove the 'ARM SCMI' prefix from module descriptions, Kconfig help texts, and comments, contradicting the commit message.
--

--- Patch [1]: [RFC PATCH] firmware: scmi: Make SCMI arch independent ---
commit 60ea398dd3e0168551de4ef6f284874ff73c9025
Author: Michal Simek <michal.simek@amd.com>

firmware: scmi: Make SCMI arch independent

This commit aims to make SCMI architecture-independent by removing ARM/ARM64
Kconfig dependencies and dropping the "ARM" prefix from descriptions, file
names, and documentation.

>     That's why get rid of ARM prefix and description from documentation, file
>     names, folder names, MODULE description, module names, Kconfig and
>     comments.
>     But keep origin Kconfig symbols not to break existing users.
>     
>     Hwmon, pinctrl, powercap, regulator, reset, clk and cpufreq scmi drivers
>     already miss arm prefix that's why synchronize all of them to be without
>     arm prefix.

[Severity: Medium]
Did we miss a few files and strings during this synchronization?

For example, drivers/hwmon/scmi-hwmon.c was omitted from the patch and still
contains:
MODULE_DESCRIPTION("ARM SCMI HWMON interface driver");

>  rename drivers/firmware/{arm_scmi => scmi}/bus.c (100%)

[Severity: Medium]
Do we also need to update the MODULE_DESCRIPTION in this file?

It currently retains: MODULE_DESCRIPTION("ARM SCMI protocol bus");

>  rename drivers/firmware/{arm_scmi => scmi}/driver.c (100%)

[Severity: Medium]
Does this file also still need its description updated?

It currently retains: MODULE_DESCRIPTION("ARM SCMI protocol driver");

>  rename drivers/firmware/{arm_scmi => scmi}/scmi_power_control.c (100%)

[Severity: Medium]
Does this file also need an update?

It currently retains: MODULE_DESCRIPTION("ARM SCMI SystemPower Control driver");

> diff --git a/drivers/powercap/Kconfig b/drivers/powercap/Kconfig
> index 03c4c796d9931..d3eda4a70978d 100644
> --- a/drivers/powercap/Kconfig
> +++ b/drivers/powercap/Kconfig
> @@ -61,7 +61,7 @@ config IDLE_INJECT
>  	  on a per CPU basis.
>  
>  config ARM_SCMI_POWERCAP
> -	tristate "ARM SCMI Powercap driver"
> +	tristate "SCMI Powercap driver"
>  	depends on ARM_SCMI_PROTOCOL
>  	help
>  	  This enables support for the ARM Powercap based on ARM SCMI

[Severity: Medium]
Should the help text here also be updated? 

It currently still references "ARM Powercap based on ARM SCMI".

>  rename drivers/firmware/{arm_scmi => scmi}/transports/Kconfig (100%)

[Severity: Medium]
Does the help text in this renamed Kconfig still need updating to match the
commit message?

Looking at ARM_SCMI_TRANSPORT_MAILBOX, the help text still mentions:
"If you want the ARM SCMI PROTOCOL stack to include support for a"

This also appears to be missed in the SMC, OPTEE, and VIRTIO blocks.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/d7f7e8c9589d937b60e43168845ab4fda15037a3.1783603600.git.michal.simek@amd.com?part=1