Re: [PATCH v15 2/6] platform: misc: add NXP MC33978/MC34978 core driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Redundant initialization of `irq_lock` mutex.
--

--- Patch [2]: [PATCH v15 2/6] platform: misc: add NXP MC33978/MC34978 core driver ---
commit 7429a33c25a8a05d13819baad0143ee08fe7eb8c
Author: Oleksij Rempel <o.rempel@pengutronix.de>

platform: misc: add NXP MC33978/MC34978 core driver

This commit adds the core support module for the NXP MC33978 and MC34978
Multiple Switch Detection Interfaces. It handles SPI communications via a
custom regmap bus, interrupt demultiplexing, and event processing.

> --- /dev/null
> +++ b/drivers/platform/misc/mc33978-core.c

[ ... ]

> @@ -759,6 +759,8 @@ static int mc33978_irq_init(struct mc33978_core_data *cdata,
>  			    struct fwnode_handle *fwnode)
>  {
>  	struct device *dev = &cdata->spi->dev;
>  	int ret;
>  
>  	mutex_init(&cdata->irq_lock);
>  
>  	/*

[ ... ]

> @@ -1146,6 +1146,8 @@ int mc33978_core_init(struct device *dev, struct spi_device *spi,
>  	cdata->spi = spi;
>  
>  	mutex_init(&cdata->event_lock);
>  	mutex_init(&cdata->irq_lock);

[Severity: Low]
This isn't a bug, but is it intentional to initialize irq_lock twice?
It is initialized here in mc33978_core_init() and also inside
mc33978_irq_init() which is called a few lines later. Doing so creates
two different static lockdep keys for the same lock.

>  	spin_lock_init(&cdata->state_lock);
>  	raw_spin_lock_init(&cdata->irq_state_lock);
>  
>  	INIT_WORK(&cdata->event_work, mc33978_event_work);
>  
>  	mc33978_prepare_messages(cdata);
>  
>  	ret = mc33978_irq_init(cdata, fwnode);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260710101358.2606941-1-o.rempel@pengutronix.de?part=2