From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21F534195D7 for ; Fri, 10 Jul 2026 11:25:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783682722; cv=none; b=XKeBknMYDGkpmwr5TfqdRF7Fvv9Gb3Yf6mubzmH1SFlO6g157Haq4I7a6oMqBfzSKOJxSmuRLHcVwD/FFm+kKHVgs5DDryYTiXekNmn6YtZiK+6S2CpHGTXBA7nF5K6qOvWErlqZ8zyYD7CDrQn/R+ul/NBqDVxDkwNd+KOec8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783682722; c=relaxed/simple; bh=kDCu1wuU7RxZMMntIXkRjFuZC3WCLuihGxnJFbWzi6k=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=t4iF23eFLjFLyQk8Zoq8rl6OkyYr334XQnBYGsPJaPx6ScYMjFWWegMKd8ZWlVksdiYwW032gWo9I18anlr5PdJQdJlhY7Z5REL3Rc3/6QEyXvVl5vnm0GDkyWske827tZYdkI6wBDOE2XgAPkdYIEGQ1I9E+PEi7O2sfFj6Ptg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kqVEJdkT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kqVEJdkT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 961EA1F000E9; Fri, 10 Jul 2026 11:25:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783682714; bh=kDCu1wuU7RxZMMntIXkRjFuZC3WCLuihGxnJFbWzi6k=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=kqVEJdkTR3sKIm74xQzT1dJkaX80osP1rUysbmVPOSBWjl3+3dUhz9jYle+gYotz7 c/VKkzdJW22C3j5LlPsrT1tL6FlFNw4qoOqz+qtuwj0xW4aiA/ZU8dYHfw+SCPThT4 aPKHhFEedIWpwxrmSbDe/W7GyP5WvzWpI5w8B7u7rXDyj6n404fV5dOfGW1U1/Z2w7 P8+8l5rc13DbPnZ7rzTxCKwTPgsSYGeWb8CeHB8asfgWBjcUidXPPhPYmg5RcDjoOs LhDs1nFgacV+KRqpqo+7AqjT4UW0Y/iyqZtuiTa+49bYfCPNHlhpcS5ljprol+9I5/ Qmettsfi4GbPQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 4/8] misc: amd-sbi: Consolidate Common SBTSI Probe Path Reply-To: sashiko-reviews@lists.linux.dev To: "Akshay Gupta" Cc: linux-hwmon@vger.kernel.org In-Reply-To: <20260710111642.850022-5-Akshay.Gupta@amd.com> References: <20260710111642.850022-1-Akshay.Gupta@amd.com> <20260710111642.850022-5-Akshay.Gupta@amd.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 10 Jul 2026 11:25:13 +0000 Message-Id: <20260710112514.961EA1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: > From: Prathima >=20 > Refactor shared probe procedures into sbtsi_probe_common() to ensure > that I2C and I3C probes focus solely on bus-specific allocation and > device configuration. > The utility function reads the configuration register via sbtsi_xfer(), > initializes ext_range_mode and read_order, assigns the driver data, > and registers the hwmon auxiliary device. > Routing register access through sbtsi_xfer() keeps the probe path > bus-agnostic, so no transfer logic has to be duplicated when SB-TSI over > I3C support is added in a later patch. >=20 > Reviewed-by: Akshay Gupta > Signed-off-by: Prathima Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260710111642.8500= 22-1-Akshay.Gupta@amd.com?part=3D4