Re: [PATCH] hwmon: (asus-ec-sensors) detect unconnected physical sensors

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The static array `temperature_blank_values` is missing the `const` qualifier.
--

--- Patch [1]: [PATCH] hwmon: (asus-ec-sensors) detect unconnected physical sensors ---
commit 674d66473a7b251333e25248978dffdc28c7dbcd
Author: Eugene Shalygin <eugene.shalygin@gmail.com>

hwmon: (asus-ec-sensors) detect unconnected physical sensors

This commit adds detection for unconnected physical temperature sensors by
checking for specific blank values (-62, -60, -40) returned by the EC
register. If a sensor is unconnected, it now returns -ENODATA to hwmon.

> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index 29a23484cbe7b..f178570110c1d 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
> @@ -67,6 +67,13 @@ static char *mutex_path_override;
>  /* Moniker for the ACPI global lock (':' is not allowed in ASL identifiers) */
>  #define ACPI_GLOBAL_LOCK_PSEUDO_PATH	":GLOBAL_LOCK"
>  
> +/*
> + * The values for temperature sensor readings without physical sensors connected.
> + * The value varies across generations and is seemingly defined by the EC chip
> + * used in the given board.
> + */
> +static s32 temperature_blank_values[] = {-62, -60, -40};

[Severity: Low]
This isn't a bug, but should this array be declared with the const
qualifier? Without it, the array will be placed in the writable data
section rather than the read-only memory section.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260711095917.568925-1-eugene.shalygin@gmail.com?part=1