Re: [PATCH v2 1/1] hwmon: (asus-ec-sensors) add missed handle for ENOMEM

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Spurious out-of-bank EC register reads due to incorrect filtering condition in asus_ec_block_read().
--

--- Patch [1]: [PATCH v2 1/1] hwmon: (asus-ec-sensors) add missed handle for ENOMEM ---
commit 6c544c8bc415253dbbfc446299b7748bcc5d2a83
Author: Eugene Shalygin <eugene.shalygin@gmail.com>

hwmon: (asus-ec-sensors) add missed handle for ENOMEM

Add missing return value check in the setup function.

> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index 29a23484cbe7b..fc58b7eb413ee 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c

[ ... ]

[Severity: High]
This isn't a bug introduced by this patch, but I noticed a potential
issue in asus_ec_block_read() while reviewing this driver.

drivers/hwmon/asus-ec-sensors.c:asus_ec_block_read() {
[ ... ]
	for (ibank = 0; ibank < ec->nr_banks; ibank++) {
		if (bank != ec->banks[ibank]) {
			bank = ec->banks[ibank];
[ ... ]
		}
		for (ireg = 0; ireg < ec->nr_registers; ireg++) {
			reg_bank = register_bank(ec->registers[ireg]);
			if (reg_bank < bank) {
				continue;
			}
			ec_read(register_index(ec->registers[ireg]),
				ec->read_buffer + ireg);
		}
	}
[ ... ]
}

Since the inner loop only skips registers from previously read banks
(reg_bank < bank), does this code mistakenly read registers intended
for future banks (where reg_bank > bank) while the hardware EC is still
switched to the current bank?

For example, if the hardware EC is switched to bank 0, would it incorrectly
read registers intended for bank 1, 2, etc., from the bank 0 hardware
interface?

Could reading arbitrary Embedded Controller registers without being in the
correct bank trigger clear-on-read side effects, disrupt state machines,
or lock up the EC?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260712130345.1256030-2-eugene.shalygin@gmail.com?part=1