Re: [PATCH 1/4] dt-bindings: hwmon: add binding for adi,adt7470

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The dt-binding for the multi-channel ADT7470 PWM fan controller omits the mandatory `#pwm-cells` property for a PWM output provider and incorrectly models the channels as a single cooling device.
--

--- Patch [1]: [PATCH 1/4] dt-bindings: hwmon: add binding for adi,adt7470 ---
commit 5b60ee676010a73eb2ebad187c402e61ddc230ad
Author: Luiz Angelo Daros de Luca <luizluca@gmail.com>

dt-bindings: hwmon: add binding for adi,adt7470

This commit adds the YAML device tree binding documentation for the Analog
Devices ADT7470 temperature monitor and PWM fan controller. It includes
support for the thermal framework by defining cooling and thermal sensor
properties.

> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adt7470.yaml b/Documentation/devicetree/bindings/hwmon/adi,adt7470.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/adi,adt7470.yaml
[ ... ]
> +properties:
> +  compatible:
> +    const: adi,adt7470
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#cooling-cells":
> +    const: 2
> +    description: |
> +      Cooling device exposing the 4 PWM channels.

[Severity: Medium]
Does defining #cooling-cells directly on the parent node force all 4 PWM
channels to be ganged together into a single cooling device? A 2-cell cooling
specifier lacks a cell for the channel index, which might permanently prevent
the thermal framework from addressing the individual fans independently. Would
it be more appropriate to model this using explicit fan sub-nodes or PWM
consumers?

> +
> +  "#thermal-sensor-cells":
> +    const: 1
> +    description: |
> +      Number of cells required to uniquely identify the temperature sensors.
> +      Valid index values are 0 to 9, corresponding to temp1 through temp10.
> +
> +required:
> +  - compatible
> +  - reg

[Severity: Medium]
Is the #pwm-cells property missing from this required list? Since the ADT7470
acts as a multi-channel PWM provider, subsystem guidelines suggest that PWM
output providers need to include #pwm-cells in both the properties and the
required list. Omitting this allows incomplete device trees to pass schema
validation.

> +
> +additionalProperties: false
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716-adt7470_thermalzone-v1-0-cc55ef35edde@gmail.com?part=1