Re: [PATCH v2 2/6] dt-bindings: hwmon: Move LM63 family to a dedicated binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing `interrupts` property in the newly created LM63 device tree binding.
--

--- Patch [2]: [PATCH v2 2/6] dt-bindings: hwmon: Move LM63 family to a dedicated binding ---
commit 5cb7233d8984d02f9823102bcec286ee4ef134d5
Author: Troy Mitchell <troy.mitchell@linux.dev>

dt-bindings: hwmon: Move LM63 family to a dedicated binding

This commit moves the National Semiconductor LM63, LM64, and LM96163
compatibles out of trivial-devices.yaml and into a dedicated schema. It also
describes their integrated fan control and thermal cooling device capabilities.

> diff --git a/Documentation/devicetree/bindings/hwmon/national,lm63.yaml b/Documentation/devicetree/bindings/hwmon/national,lm63.yaml
> new file mode 100644
> index 0000000000000..92b0094ff3034
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/national,lm63.yaml

[ ... ]

> +properties:
> +  compatible:
> +    enum:
> +      - national,lm63
> +      - national,lm64
> +      - national,lm96163
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#cooling-cells":
> +    const: 2

[Severity: Medium]
Should the interrupts property be explicitly defined in this block?

Because the LM63 family was moved out of trivial-devices.yaml (which broadly 
permitted the interrupts property) to a dedicated schema using
unevaluatedProperties: false, device trees that correctly describe the 
hardware's interrupt capability via the ALERT# pin will now incorrectly fail 
dtbs_check validation.

> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260721-ctl2301-v2-0-ef5fb342872a@linux.dev?part=2