From: sashiko-bot@kernel.org
To: "Guenter Roeck" <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (pmbus) Fix return value from pmbus_update_byte_data()
Date: Tue, 28 Jul 2026 15:54:27 +0000 [thread overview]
Message-ID: <20260728155427.BD3141F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260728154657.3910899-1-linux@roeck-us.net>
> pmbus_update_byte_data() is supposed to return a negative error code or 0.
> However, if no change is made to the register, it actually returns the
> register value. This can result in problems if the calling code explicitly
> expects to see an error code or 0.
>
> Fix it to return 0 on success or the error code as expected.
>
> Fixes: 11c119986f270 ("hwmon: (pmbus) add helpers for byte write and read modify write")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260728154657.3910899-1-linux@roeck-us.net?part=1
prev parent reply other threads:[~2026-07-28 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 15:46 [PATCH] hwmon: (pmbus) Fix return value from pmbus_update_byte_data() Guenter Roeck
2026-07-28 15:54 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728155427.BD3141F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox