Re: [hwmon-next PATCH v4 1/4] dt-bindings: hwmon: add adi,adt7470

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding defines PWM capabilities for the fan control lines but fails to include `#pwm-cells` in the `required` array.
--

--- Patch [1]: [hwmon-next PATCH v4 1/4] dt-bindings: hwmon: add adi,adt7470 ---
commit d94dd40d08b4e7af2118277171ae57575a6cb4c8
Author: Luiz Angelo Daros de Luca <luizluca@gmail.com>

dt-bindings: hwmon: add adi,adt7470

This commit adds the device tree binding documentation for the Analog Devices
ADT7470 multichannel temperature sensor and PWM fan controller. It includes
support for the thermal framework and models fan control lines as PWM channels.

> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adt7470.yaml b/Documentation/devicetree/bindings/hwmon/adi,adt7470.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/adi,adt7470.yaml
[ ... ]
> +  "#pwm-cells":
> +    const: 3
> +
> +  "#thermal-sensor-cells":
> +    const: 1
> +    description:
> +      Valid index values are 0 to 9, corresponding to temp1 through temp10.
> +
> +required:
> +  - compatible
> +  - reg

[Severity: Medium]
Since the binding defines PWM capabilities for the fan control lines, should
#pwm-cells be included in the required properties list? Without it, a device
tree node omitting the property will still pass schema validation, which
could lead to runtime failures in drivers or dependent subsystems attempting
to use the PWM functionality.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260729-adt7470_thermalzone-v4-0-c14039dfa0e6@gmail.com?part=1