Re: [hwmon-next PATCH v5 1/4] dt-bindings: hwmon: add adi,adt7470

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The provider capability property `#pwm-cells` is omitted from the `required` list despite the hardware functioning as a PWM provider.
--

--- Patch [1]: [hwmon-next PATCH v5 1/4] dt-bindings: hwmon: add adi,adt7470 ---
commit 5105b0d67f8fd87224b8f539a86af2d5d3710517
Author: Luiz Angelo Daros de Luca <luizluca@gmail.com>

dt-bindings: hwmon: add adi,adt7470

This commit adds device tree binding documentation for the Analog Devices
ADT7470 multichannel temperature sensor and PWM fan controller. It defines
properties for thermal sensors and models the fan control lines as PWM
channels.

> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adt7470.yaml b/Documentation/devicetree/bindings/hwmon/adi,adt7470.yaml
> new file mode 100644
> index 0000000000000..f653a06f241aa
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/adi,adt7470.yaml
> @@ -0,0 +1,58 @@

[ ... ]

> +properties:
> +  compatible:
> +    const: adi,adt7470
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#pwm-cells":
> +    const: 3
> +
> +  "#thermal-sensor-cells":
> +    const: 1
> +    description:
> +      Valid index values are 0 to 9, corresponding to temp1 through temp10.
> +
> +required:
> +  - compatible
> +  - reg

[Severity: Medium]
Since the device acts as a PWM provider and defines #pwm-cells, should
#pwm-cells be added to this required list? 

The device tree bindings subsystem guidelines state that when a device adds
provider capabilities like PWM output, the corresponding standard properties
must appear in the required list. Without it, incomplete device tree nodes
that are missing #pwm-cells will pass schema validation, which could mask
configurations that will fail at runtime when dependent consumers attempt to
use the PWM capability.

> +
> +unevaluatedProperties: false

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730-adt7470_thermalzone-v5-0-42995a6bb8c5@gmail.com?part=1