Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 2/2] thermal: hwmon: Remove hwmon class device along with its parent
Date: Tue, 04 Aug 2026 20:19:33 +0000	[thread overview]
Message-ID: <20260804201934.022AE1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <5094738.GXAFRqVoOG@rafael.j.wysocki>

> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> The current code creates one hwmon device per thermal zone type and that
> device is registered under the first thermal zone of the given type.
> 
> That turns out to be problematic when the thermal zone holding the
> hwmon device is removed.
> 
> For example, say that there are two ACPI thermal zones on a system
> 
>  /sys/devices/virtual/thermal/thermal_zone0/
>  /sys/devices/virtual/thermal/thermal_zone1/
> 
> The current code registers a hwmon class device for thermal_zone0 only:
> 
> [ ... ]
> the current kernel coding style to align with the new "unlock" label.
> 
> Link: https://lore.kernel.org/linux-pm/20260402021828.16556-1-liujia6264@gmail.com/
> Fixes: f6b6b52ef7a5 ("thermal_hwmon: Pass the originating device down to hwmon_device_register_with_info")
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/12947893.O9o76ZdvQC@rafael.j.wysocki?part=2


  reply	other threads:[~2026-08-04 20:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04 20:06 [PATCH v2 0/2] thermal: hwmon: Fix thermal zone removal deadlock Rafael J. Wysocki
2026-08-04 20:09 ` [PATCH v2 1/2] Revert "thermal/drivers/hwmon: Cleanup coding style a bit" Rafael J. Wysocki
2026-08-04 20:24   ` sashiko-bot
2026-08-05 10:32   ` Lukasz Luba
2026-08-05 11:53     ` Rafael J. Wysocki (Intel)
2026-08-04 20:11 ` [PATCH v2 2/2] thermal: hwmon: Remove hwmon class device along with its parent Rafael J. Wysocki
2026-08-04 20:19   ` sashiko-bot [this message]
2026-08-05 10:40   ` Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260804201934.022AE1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox