From: sashiko-bot@kernel.org
To: "Guenter Roeck" <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (pmbus/lm25066) Fix PMBus coefficient calculations
Date: Tue, 04 Aug 2026 21:44:22 +0000 [thread overview]
Message-ID: <20260804214422.E7E851F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260804213627.1522664-1-linux@roeck-us.net>
> In lm25066_probe(), the PMBus coefficients for current and power are
> scaled based on the shunt resistor value. The calculation evaluates the
> multiplication using 32-bit arithmetic because info->m is an int and
> shunt is a u32:
>
> static int lm25066_probe(struct i2c_client *client) {
> ...
> info->m[PSC_CURRENT_IN] = info->m[PSC_CURRENT_IN] * shunt / 1000;
> info->m[PSC_POWER] = info->m[PSC_POWER] * shunt / 1000;
> ...
> }
>
> For large coefficients like 26882 (LM25056) or 15076 (LM5066i), a device
> tree shunt-resistor-micro-ohms value exceeding approximately 159,000
> (159 mOhm, which is physically valid for low-current applications) causes
> [ ... ]
> shunt resistor values.
>
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Fixes: 94ee5fcc240fe ("hwmon: (pmbus/lm25066) Support configurable sense resistor values")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260804213627.1522664-1-linux@roeck-us.net?part=1
prev parent reply other threads:[~2026-08-04 21:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 21:36 [PATCH] hwmon: (pmbus/lm25066) Fix PMBus coefficient calculations Guenter Roeck
2026-08-04 21:44 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804214422.E7E851F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox