From: sashiko-bot@kernel.org
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 3/3] hwmon: (sysfs) Allow drivers to register const attributes
Date: Thu, 06 Aug 2026 06:16:30 +0000 [thread overview]
Message-ID: <20260806061631.208091F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260806-sysfs-const-attr-hwmon-v2-3-22fee8b85509@weissschuh.net>
> Switch to the __DEVICE_ATTR() macro which can handle callbacks taking
> both const and non-const attribute structure arguments.
> Allow the step-wise migration of the drivers.
>
> Also use container_of_const() over container_of() to avoid casting away
> the constness accidentally.
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260806-sysfs-const-attr-hwmon-v2-0-22fee8b85509@weissschuh.net?part=3
next prev parent reply other threads:[~2026-08-06 6:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 6:09 [PATCH v2 0/3] hwmon: Handle const struct attributes Thomas Weißschuh
2026-08-06 6:09 ` [PATCH v2 1/3] hwmon: (core) Constify device attributes Thomas Weißschuh
2026-08-06 6:20 ` sashiko-bot
2026-08-06 19:19 ` Guenter Roeck
2026-08-06 6:09 ` [PATCH v2 2/3] hwmon: (core) Use const APIs for the dynamically allocated sysfs attributes Thomas Weißschuh
2026-08-06 6:15 ` sashiko-bot
2026-08-06 19:20 ` Guenter Roeck
2026-08-06 6:09 ` [PATCH v2 3/3] hwmon: (sysfs) Allow drivers to register const attributes Thomas Weißschuh
2026-08-06 6:16 ` sashiko-bot [this message]
2026-08-06 19:20 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260806061631.208091F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox