From: sashiko-bot@kernel.org
To: "Nikhil Gurudasani" <nikhilgurudasani314@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (mcp9982) Propagate one-shot polling errors
Date: Wed, 19 Aug 2026 18:12:49 +0000 [thread overview]
Message-ID: <20260819181249.96BA61F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260819180701.34797-1-nikhilgurudasani314@gmail.com>
> When a device is in standby, the driver starts a one-shot conversion and
> polls the BUSY flag before reading temperature, alarm, or fault data.
> The poll result is currently ignored. Therefore, a timeout or a
> status-register read failure can be hidden by a later successful read,
> causing stale data to be returned as valid.
>
> Return the polling error before reading the requested attribute.
>
> Fixes: e2fe950f34e5 ("hwmon: add support for MCP998X")
> Cc: stable@vger.kernel.org
> Signed-off-by: Nikhil Gurudasani <nikhilgurudasani314@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260819180701.34797-1-nikhilgurudasani314@gmail.com?part=1
next prev parent reply other threads:[~2026-08-19 18:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 18:07 [PATCH] hwmon: (mcp9982) Propagate one-shot polling errors Nikhil Gurudasani
2026-08-19 18:12 ` sashiko-bot [this message]
2026-08-19 20:34 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260819181249.96BA61F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=nikhilgurudasani314@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox