Re: [PATCH 1/2] dt-bindings: hwmon: national,lm90: Fix channel constraints for temperature offset

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unanchored regular expressions in `patternProperties` violate dt-bindings conventions by matching substrings instead of exact node names.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: hwmon: national,lm90: Fix channel constraints for temperature offset ---
commit 9782538dd0bd62fc7f4323e17bb521a9d2fa819b
Author: Flaviu Nistor <flaviu.nistor@gmail.com>

dt-bindings: hwmon: national,lm90: Fix channel constraints for temperature offset

This commit limits the temperature-offset-millicelsius property to remote
channels only, as it doesn't apply to the local channel 0. It also rejects
channel 2 for devices that do not support a second remote channel.

> diff --git a/Documentation/devicetree/bindings/hwmon/national,lm90.yaml b/Documentation/devicetree/bindings/hwmon/national,lm90.yaml
> index 164068ba069d7..a7f82b202b861 100644
> --- a/Documentation/devicetree/bindings/hwmon/national,lm90.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/national,lm90.yaml
[ ... ]
> @@ -113,6 +113,29 @@ allOf:
>        properties:
>          ti,extended-range-enable: false
>  
> +  - patternProperties:
> +      "channel@0":

[Severity: Low]
Should this regular expression be anchored as "^channel@0$"?

Without anchors, this matches any child node containing "channel@0" as a
substring (such as "mychannel@0"), causing incorrect schema validation rules
to be applied during dt_binding_check execution.

> +        type: object
> +        properties:
> +          temperature-offset-millicelsius: false
> +
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            contains:
> +              enum:
> +                - adi,adt7481
> +                - dallas,max6695
> +                - dallas,max6696
> +    then:
> +      patternProperties:
> +        "^channel@[0-1]$":
> +          properties:
> +            reg:
> +              enum: [0, 1]
> +        "channel@2": false

[Severity: Low]
Does this pattern also need to be anchored as "^channel@2$"?

As written, it behaves as a substring match and might inadvertently reject
node names containing it as a substring.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824183900.8983-1-flaviu.nistor@gmail.com?part=1