Re: [PATCH net-next v2 5/6] eth: fbnic: report temperature and voltage alarms via hwmon

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Medium] Hardware monitoring functionality is implemented directly within the network driver directory instead of using the auxiliary device framework to place it in drivers/hwmon/.
--

--- Patch [5]: [PATCH net-next v2 5/6] eth: fbnic: report temperature and voltage alarms via hwmon ---
commit ce6680b733799ddad39ba8fc00bdbf073f5793f7
Author: Zinc Lim <limzhineng2@gmail.com>

eth: fbnic: report temperature and voltage alarms via hwmon

This commit exposes temperature and voltage alarm attributes through the hwmon
interface based on static thresholds stored in fbnic_fw_cap. The alarms are
computed dynamically by taking live sensor readings and comparing them against
these thresholds.

> diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_hwmon.c b/drivers/net/ethernet/meta/fbnic/fbnic_hwmon.c
> index 4938f7b391402..c5cddd9cef124 100644
> --- a/drivers/net/ethernet/meta/fbnic/fbnic_hwmon.c
> +++ b/drivers/net/ethernet/meta/fbnic/fbnic_hwmon.c

[ ... ]

[Severity: Medium]
This is a pre-existing issue, but I noticed an architectural violation in how
the hardware monitoring functionality is registered in this file:

drivers/net/ethernet/meta/fbnic/fbnic_hwmon.c:fbnic_hwmon_register() {
    ...
	fbd->hwmon = hwmon_device_register_with_info(fbd->dev, "fbnic",
						     fbd, &fbnic_chip_info,
						     NULL);
    ...
}

Is it appropriate to register this hardware monitoring device directly from
the network driver directory?

According to the hwmon subsystem guidelines, if the main functionality of a
chip is not hardware monitoring, its hardware monitoring functionality should
be implemented as an auxiliary device driver residing in drivers/hwmon/.

Could this direct registration bypass the required layering and maintainer
review for hardware monitoring devices?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260824175059.2485048-1-limzhineng2@gmail.com?part=5