Re: [PATCH v3 1/1] hwmon: Add Minisforum UM780 XTX EC monitoring and fan control

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing Kconfig dependency on ACPI_EC leads to undefined reference errors at link time.
--

commit 95c2944ab1799dbc9f42157b5a4c6a9050da57ae
Author: Sebastián Peyrott <speyrott@gmail.com>

hwmon: Add Minisforum UM780 XTX EC monitoring and fan control

This commit adds a DMI-gated hardware monitoring driver for the embedded
controller used by the Minisforum UM780 XTX. It exposes CPU and system fan
control temperatures and tachometers, utilizing the ACPI EC transport.

> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 81a9a1d40eec8..45ac04c89b23d 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
[ ... ]
> @@ -1490,6 +1490,22 @@ config SENSORS_MENF21BMC_HWMON
>  	  This driver can also be built as a module. If so the module
>  	  will be called menf21bmc_hwmon.
>  
> +config SENSORS_MINISFORUM_UM780XTX
> +	tristate "Minisforum UM780 XTX EC hardware monitoring"
> +	depends on ACPI && DMI && X86

[Severity: Low]
Does this also need to depend on ACPI_EC? 

If a user configures the kernel with CONFIG_ACPI enabled but leaves 
CONFIG_ACPI_EC unselected, will this driver fail to build? It appears this
would lead to undefined references to ec_read, ec_write, ec_transaction,
and ec_get_handle at link time.

> +	help
> +	  If you say yes here you get support for the hardware monitoring
> +	  features of the embedded controller in the Minisforum UM780 XTX.
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260825184107.355980-2-speyrott@gmail.com?part=1