Re: [PATCH 2/2] hwmon: (pmbus/tda38740) Add driver for Infineon TDA38740/TDA38725

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The i2c_device_id array uses unnamed (positional) initializers, violating the I2C subsystem guidelines.
--

commit eb4e8412377fc06c23e75ea2aa72286755317004
Author: Colin Huang <u8813345@gmail.com>

hwmon: (pmbus/tda38740) Add driver for Infineon TDA38740/TDA38725

This commit adds a new PMBus driver for the Infineon TDA38740 and TDA38725
single-voltage synchronous buck regulators.

> diff --git a/drivers/hwmon/pmbus/tda38740.c b/drivers/hwmon/pmbus/tda38740.c
> new file mode 100644
> index 0000000000000..4217a5a9ee661
> --- /dev/null
> +++ b/drivers/hwmon/pmbus/tda38740.c

[ ... ]

> +static int tda38740_probe(struct i2c_client *client)
> +{
> +	struct tda38740_data *data;
> +
> +	data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL);
> +	if (!data)
> +		return -ENOMEM;
> +	memcpy(&data->info, &tda38740_info, sizeof(tda38740_info));
> +
> +	return pmbus_do_probe(client, &data->info);
> +}
> +
> +static const struct i2c_device_id tda38740_id[] = {
> +	{"tda38725"},
> +	{"tda38740"},
> +	{}
> +};

[Severity: Low]
Could we update this i2c_device_id array to use C99 named initializers? The
I2C subsystem guidelines mandate the use of named initializers for initialized
arrays of type struct i2c_device_id.

> +MODULE_DEVICE_TABLE(i2c, tda38740_id);

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907-add-tda38740-and-tda38725-v1-0-e2db1b2566b1@gmail.com?part=2