From: sashiko-bot@kernel.org
To: "Colin Huang" <colin.huang2@amd.com>
Cc: conor+dt@kernel.org, robh@kernel.org,
linux-hwmon@vger.kernel.org, wsa+renesas@sang-engineering.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] hwmon: (pmbus/isl68137): Add Renesas RAA229639 and RAA229640
Date: Tue, 08 Sep 2026 07:11:27 +0000 [thread overview]
Message-ID: <20260908071127.B406E1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260908-add-raa229639-and-raa229640-v2-2-83c75b61139d@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added devices RAA229639 and RAA229640 are not documented in the supported chips list.
--
commit 1702c94b50317002cdd0b95f06c65c3af4214d35
Author: Colin Huang <u8813345@gmail.com>
hwmon: (pmbus/isl68137): Add Renesas RAA229639 and RAA229640
This commit adds support for the Renesas RAA229639 and RAA229640 PMBus
voltage regulator devices. It updates the existing raa_dmpvr2_2rail driver
variant by adding the corresponding device IDs and OF match entries.
> diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
> index 2f7f825bfb69e..53b44775ba1e6 100644
> --- a/drivers/hwmon/pmbus/isl68137.c
> +++ b/drivers/hwmon/pmbus/isl68137.c
> @@ -456,6 +456,8 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
> { .name = "raa229004", .driver_data = raa_dmpvr2_2rail },
> { .name = "raa229141", .driver_data = raa_dmpvr2_2rail_pmbus },
> { .name = "raa229621", .driver_data = raa_dmpvr2_2rail },
> + { .name = "raa229639", .driver_data = raa_dmpvr2_2rail },
> + { .name = "raa229640", .driver_data = raa_dmpvr2_2rail },
[Severity: Low]
Since these new devices are being added to the driver, should they also be
documented in the "Supported chips" list within
Documentation/hwmon/isl68137.rst alongside the existing parts?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260908-add-raa229639-and-raa229640-v2-0-83c75b61139d@gmail.com?part=2
prev parent reply other threads:[~2026-09-08 7:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 7:04 [PATCH v2 0/2] Support RAA229639 and RAA229640 Colin Huang
2026-09-08 7:04 ` [PATCH v2 1/2] dt-bindings: hwmon: pmbus: isl68137: Add Renesas " Colin Huang
2026-09-08 7:08 ` sashiko-bot
2026-09-08 18:02 ` Conor Dooley
2026-09-08 7:04 ` [PATCH v2 2/2] hwmon: (pmbus/isl68137): " Colin Huang
2026-09-08 7:11 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260908071127.B406E1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=colin.huang2@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox