Re: [PATCH v2 2/2] platform/arm64: add Lenovo Yoga Slim 7x Gen 11 EC driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The driver registers a hardware monitoring device directly from the platform subsystem instead of using an auxiliary device driver in drivers/hwmon/.
--

commit e4cf7bc1c28af5add49d271e2e8e75723c9146db
Author: Oleg Keri <okerixx@gmail.com>

platform/arm64: add Lenovo Yoga Slim 7x Gen 11 EC driver

This commit adds an embedded controller driver for the Lenovo Yoga Slim 7x
Gen 11 laptop on the Snapdragon X2 Elite platform. It exposes hwmon channels
for thermistors, battery cell voltages, and fan speed, as well as an LED for
the keyboard backlight and hotkey input events.

> diff --git a/drivers/platform/arm64/lenovo-yoga-slim7x-gen11-ec.c b/drivers/platform/arm64/lenovo-yoga-slim7x-gen11-ec.c
> new file mode 100644
> --- /dev/null
> +++ b/drivers/platform/arm64/lenovo-yoga-slim7x-gen11-ec.c
[ ... ]
> +static int yoga_ec_probe(struct i2c_client *client)
> +{
[ ... ]
> +	dev_dbg(dev, "thermistors present: %#lx\n", ec->temp_present);
> +
> +	hwmon = devm_hwmon_device_register_with_info(dev, "yoga_slim7x_ec", ec,
> +						     &yoga_ec_chip_info, NULL);

[Severity: Medium]
Does this bypass the hwmon subsystem maintainer review and violate subsystem
architectural layering rules by registering a hwmon device directly from a
platform multi-function device driver?

The driver registers a hardware monitoring device directly from the platform
subsystem. Should this hardware monitoring functionality be implemented as an
auxiliary device driver residing in drivers/hwmon/ instead?

> +	if (IS_ERR(hwmon))
> +		return PTR_ERR(hwmon);
> +
> +	ec->kbd_led.name = "platform::kbd_backlight";
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908183403.2107-1-okerixx@gmail.com?part=2