Re: [PATCH 06/14] mfd: remove unused da903x driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete driver removal leaves behind orphaned header, MAINTAINERS entry, and stale defconfig options.
--

commit 5d7f5a2366c42ef6c4fd37de982c54aaa25f59e1
Author: Arnd Bergmann <arnd@arndb.de>

mfd: remove unused da903x driver

This driver was used on a handful of ARM/PXA boards until those
got removed a few years ago. Without devicetree support, there is
no way to use them upstream.

> diff --git a/MAINTAINERS b/MAINTAINERS
> index ce681f5e08967..43355bffc6100 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7575,7 +7575,6 @@ F:	drivers/input/misc/da72??.[ch]
>  F:	drivers/input/misc/da90??_onkey.c
>  F:	drivers/input/touchscreen/da9052_tsi.c
>  F:	drivers/leds/leds-da90??.c
> -F:	drivers/mfd/da903x.c
>  F:	drivers/mfd/da90??-*.c

[Severity: Low]
Does this incomplete removal leave behind the orphaned header file
include/linux/mfd/da903x.h? It appears the header is no longer used but
was not deleted in this commit.

Additionally, should the MAINTAINERS entry for include/linux/mfd/da903x.h
(at line 7590) be removed along with it?

Finally, are there stale defconfig options (CONFIG_PMIC_DA903X=y) left in
arch/arm/configs/pxa_defconfig (at line 322) and
arch/arm/configs/pxa3xx_defconfig (at line 57) that should be cleaned
up as well, to avoid minor kernel configuration warnings when running
make defconfig?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909132153.1596191-1-arnd@kernel.org?part=6