From: sashiko-bot@kernel.org
To: "Thomas Richard (congatec GmbH)" <thomas.richard@bootlin.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 1/2] hwmon: (cgbc-hwmon): Fix current sensors ID lookup
Date: Thu, 10 Sep 2026 13:45:12 +0000 [thread overview]
Message-ID: <20260910134512.C8DE51F00899@smtp.kernel.org> (raw)
In-Reply-To: <20260910-cgbc-hwmon-fix-and-new-sensors-v1-1-ef13ae2fa147@bootlin.com>
> Current sensors on the Congatec Board Controller don't use consecutive IDs,
> unlike other sensor types (voltage, temperature, fan). The driver assumed
> consecutive IDs and performed a simple lookup, which caused an unknown
> sensor warning. Define current sensor IDs explicitly.
>
> Changes the warning on conga-SA7 (type and channel are correct now).
> Before:
> Board Controller returned an unknown sensor (type=2, channel=17), ignore it
> After:
> Board Controller returned an unknown sensor (bc_type=1, bc_id=11), ignore it
>
> Cc: stable@kernel.org
> Fixes: 08ebc9def79f ("hwmon: Add Congatec Board Controller monitoring driver")
> Signed-off-by: Thomas Richard (congatec GmbH) <thomas.richard@bootlin.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-cgbc-hwmon-fix-and-new-sensors-v1-0-ef13ae2fa147@bootlin.com?part=1
next prev parent reply other threads:[~2026-09-10 13:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 13:28 [PATCH 0/2] Congatec Board Controller: Fix current sensor lookup and add new sensors Thomas Richard (congatec GmbH)
2026-09-10 13:28 ` [PATCH 1/2] hwmon: (cgbc-hwmon): Fix current sensors ID lookup Thomas Richard (congatec GmbH)
2026-09-10 13:45 ` sashiko-bot [this message]
2026-09-11 0:58 ` Guenter Roeck
2026-09-11 7:23 ` Thomas Richard
2026-09-11 13:57 ` Guenter Roeck
2026-09-11 17:33 ` Thomas Richard
2026-09-10 13:28 ` [PATCH 2/2] hwmon: (cgbc-hwmon): Add some temperature sensors Thomas Richard (congatec GmbH)
2026-09-10 13:45 ` sashiko-bot
2026-09-10 14:56 ` Guenter Roeck
2026-09-11 0:59 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260910134512.C8DE51F00899@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=thomas.richard@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox