Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Troy Mitchell" <troy.mitchell@linux.dev>
Cc: robh@kernel.org, conor+dt@kernel.org,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 6/6] riscv: dts: spacemit: Add CTF2301 on K3 CoM260
Date: Mon, 14 Sep 2026 08:29:16 +0000	[thread overview]
Message-ID: <20260914082916.E8DA21F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260914-ctl2301-v5-6-522def70acb4@linux.dev>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree compatible string 'sensylink,ctf2301' is not documented in any device tree binding schema.
--

commit 77a2bf7d68544cb03c47870ccfe7a3ad4b0a68f4
Author: Troy Mitchell <troy.mitchell@linux.dev>

riscv: dts: spacemit: Add CTF2301 on K3 CoM260

This commit enables I2C6 on the K3 CoM260 module and adds a node to describe
the Sensylink CTF2301 temperature sensor and fan controller. It also sets
the I2C6 pin power source to a board-specific IO rail voltage.

> diff --git a/arch/riscv/boot/dts/spacemit/k3-com260.dtsi b/arch/riscv/boot/dts/spacemit/k3-com260.dtsi
> index 37627963a6492..92dea86397798 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-com260.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k3-com260.dtsi
[ ... ]
> +&i2c6 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&i2c6_1_cfg>;
> +	status = "okay";
> +
> +	temperature-sensor@4c {
> +		compatible = "sensylink,ctf2301";

[Severity: Low]
Does this compatible string introduce validation warnings?

When building the device tree with schema validation enabled, the
"sensylink,ctf2301" compatible string under the temperature-sensor@4c node
will trigger dtbs_check warnings because it is not documented in any device
tree binding schema.

While the "sensylink" vendor prefix is present in the vendor-prefixes.yaml
file, the device-specific compatible string "sensylink,ctf2301" appears to
be missing from the binding schemas (e.g., hwmon/national,lm63.yaml).

> +		reg = <0x4c>;
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914-ctl2301-v5-0-b44b81cd2c3c@linux.dev?part=6

  reply	other threads:[~2026-09-14  8:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14  8:03 [PATCH v5 0/6] hwmon: (lm63) Add Sensylink CTF2301 support Troy Mitchell
2026-09-14  8:03 ` [PATCH v5 1/6] dt-bindings: vendor-prefixes: Add Sensylink Troy Mitchell
2026-09-14  8:21   ` sashiko-bot
2026-09-14 15:26   ` Guenter Roeck
2026-09-14  8:03 ` [PATCH v5 2/6] dt-bindings: hwmon: Move LM63 family to a dedicated binding Troy Mitchell
2026-09-14  8:24   ` sashiko-bot
2026-09-14 15:27   ` Guenter Roeck
2026-09-14  8:18 ` [PATCH v5 3/6] dt-bindings: hwmon: Add Sensylink CTF2301 Troy Mitchell
2026-09-14  8:23   ` sashiko-bot
2026-09-14 15:27   ` Guenter Roeck
2026-09-14  8:18 ` [PATCH v5 4/6] hwmon: (lm63) Add Sensylink CTF2301 support Troy Mitchell
2026-09-14  8:35   ` sashiko-bot
2026-09-14 15:28   ` Guenter Roeck
2026-09-14  8:18 ` [PATCH v5 5/6] riscv: dts: spacemit: Add K3 I2C6 pinctrl state Troy Mitchell
2026-09-14  8:23   ` sashiko-bot
2026-09-15  9:04   ` Yixun Lan
2026-09-14  8:18 ` [PATCH v5 6/6] riscv: dts: spacemit: Add CTF2301 on K3 CoM260 Troy Mitchell
2026-09-14  8:29   ` sashiko-bot [this message]
2026-09-15  9:05   ` Yixun Lan
2026-09-18 23:37 ` (subset) [PATCH v5 0/6] hwmon: (lm63) Add Sensylink CTF2301 support Yixun Lan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260914082916.E8DA21F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=troy.mitchell@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox