From: sashiko-bot@kernel.org
To: "Pawel Zalewski" <pzalewski@thegoodpenguin.co.uk>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: acpi_power_meter: use named initializers for acpi_device_id
Date: Tue, 15 Sep 2026 13:44:54 +0000 [thread overview]
Message-ID: <20260915134454.DEB911F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260915-acpi-hwmon-v1-1-20747f6fd218@thegoodpenguin.co.uk>
> Use a designated initializer for the acpi_device_id fields which makes the
> code more readable and consistent with how lists are initialized in the
> rest of the kernel code base. Also drop explicitly setting fields to 0
> where it is redundant.
>
> Unify the list terminator to have a single space between the brackets and
> no trailing comma.
>
> Signed-off-by: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260915-acpi-hwmon-v1-1-20747f6fd218@thegoodpenguin.co.uk?part=1
next prev parent reply other threads:[~2026-09-15 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 13:40 [PATCH] hwmon: acpi_power_meter: use named initializers for acpi_device_id Pawel Zalewski
2026-09-15 13:44 ` sashiko-bot [this message]
2026-09-15 14:54 ` Guenter Roeck
2026-09-15 15:26 ` Pawel Zalewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915134454.DEB911F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=pzalewski@thegoodpenguin.co.uk \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox