From: sashiko-bot@kernel.org
To: "Muhammad Bilal" <meatuni001@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (hp-wmi-sensors) Fix use-after-free in fungible_show()
Date: Wed, 16 Sep 2026 00:38:53 +0000 [thread overview]
Message-ID: <20260916003854.26AF61F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260916002926.161595-1-meatuni001@gmail.com>
> nsensor->current_state is dynamically replaced as the sensor's state
> changes. update_numeric_sensor_from_wobj() does this by freeing the
> old string and installing a new one:
>
> if (strcmp(trimmed, nsensor->current_state)) {
> new_string = hp_wmi_strdup(dev, trimmed);
> if (new_string) {
> devm_kfree(dev, nsensor->current_state);
> nsensor->current_state = new_string;
> }
> }
>
> This function is only ever called from hp_wmi_update_info() while
> state->lock is held, so the free-and-replace itself is properly
> serialized against concurrent updates.
> [ ... ]
> update_numeric_sensor_from_wobj().
>
> Fixes: 23902f98f8d4 ("hwmon: add HP WMI Sensors driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Muhammad Bilal <meatuni001@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260916002926.161595-1-meatuni001@gmail.com?part=1
next prev parent reply other threads:[~2026-09-16 0:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 0:29 [PATCH] hwmon: (hp-wmi-sensors) Fix use-after-free in fungible_show() Muhammad Bilal
2026-09-16 0:38 ` sashiko-bot [this message]
2026-09-16 5:23 ` James Seo
2026-09-16 14:55 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916003854.26AF61F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=meatuni001@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox