Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jian Zhang" <zhangjian.3032@bytedance.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: peci: dimmtemp: Retry unstable DIMM mask detection
Date: Fri, 18 Sep 2026 03:27:15 +0000	[thread overview]
Message-ID: <20260918032715.BA5721F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260918031831.1937973-1-zhangjian.3032@bytedance.com>

> Add a stable DIMM mask check around PECI DIMM discovery.
> 
> During host DIMM initialization, PECI can answer the DIMM temperature
> configuration reads before every DIMM has reached a stable ready state.
> There is no separate all-DIMM-ready signal for this driver to wait on,
> so a single early read can capture only part of the populated DIMM mask.
> Retrying the mask check avoids locking that transient state into the
> hwmon device layout.
> 
> The first successful scan is saved, and the driver immediately scans
> again before registering hwmon channels. If the two masks differ, the
> driver returns -EAGAIN so the existing delayed detection work can retry
> instead of exposing a partial channel set.
> 
> Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918031831.1937973-1-zhangjian.3032@bytedance.com?part=1


  reply	other threads:[~2026-09-18  3:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18  3:18 [PATCH] hwmon: peci: dimmtemp: Retry unstable DIMM mask detection Jian Zhang
2026-09-18  3:27 ` sashiko-bot [this message]
2026-09-18 16:59 ` Guenter Roeck
2026-09-20  2:59   ` Jian Zhang
2026-09-25 20:05     ` Winiarska, Iwona

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260918032715.BA5721F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=zhangjian.3032@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox