Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Lin Wang" <wanglin@open-hieco.net>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v6 1/8] x86/hygon: Add Family 0x18 DF node enumeration
Date: Mon, 21 Sep 2026 06:02:36 +0000	[thread overview]
Message-ID: <20260921060238.E346B1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260921055603.25112-2-wanglin@open-hieco.net>

> The AMD node code locates function 3 for node N at PCI slot 0x18 + N.
> Hygon has no equivalent node-index-to-slot mapping: DF F3 devices are
> discovered by PCI ID and the PCI BDF is only an access point.
> 
> Add a Hygon node cache that enumerates DF devices by PCI ID and obtains
> the socket ID and DFID for each node from DF configuration registers.
> Validate the enumerated socket set against the hardware-reported socket
> mask before making the cache available.
> 
> Place Core and DDR Dies (CDDs) before I/O Dies (IODs) and order each
> group by socket and DFID to provide dense node indices. Export
> interfaces for node counts and identity, F3/F4 lookup, and PCI
> device-to-node lookup.
> 
> Signed-off-by: Lin Wang <wanglin@open-hieco.net>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260921055603.25112-1-wanglin@open-hieco.net?part=1


  reply	other threads:[~2026-09-21  6:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21  5:55 [PATCH v6 0/8] x86/hygon: Add Family 0x18 DF node enumeration and SMN access Lin Wang
2026-09-21  5:55 ` [PATCH v6 1/8] x86/hygon: Add Family 0x18 DF node enumeration Lin Wang
2026-09-21  6:02   ` sashiko-bot [this message]
2026-09-30  0:43   ` Borislav Petkov
2026-09-30  1:46     ` Lin Wang
2026-09-21  5:55 ` [PATCH v6 2/8] x86/hygon: Map CPU NodeIds to DF nodes Lin Wang
2026-09-21  6:02   ` sashiko-bot
2026-09-30  3:00   ` Borislav Petkov
2026-09-30  7:03     ` Lin Wang
2026-09-21  5:55 ` [PATCH v6 3/8] EDAC/amd64: Stop matching Hygon CPUs Lin Wang
2026-09-21  6:01   ` sashiko-bot
2026-09-21  5:55 ` [PATCH v6 4/8] RAS/AMD/ATL: Match AMD CPUs only Lin Wang
2026-09-21  6:02   ` sashiko-bot
2026-09-21  5:56 ` [PATCH v6 5/8] hwmon: (k10temp) Stop matching Hygon devices Lin Wang
2026-09-21  6:01   ` sashiko-bot
2026-09-21 14:54   ` Guenter Roeck
2026-09-21  5:56 ` [PATCH v6 6/8] x86/amd_nb: Restrict the northbridge framework to AMD CPUs Lin Wang
2026-09-21  6:04   ` sashiko-bot
2026-09-21  5:56 ` [PATCH v6 7/8] x86/amd_node: Restrict SMN setup " Lin Wang
2026-09-21  6:04   ` sashiko-bot
2026-09-21  5:56 ` [PATCH v6 8/8] x86/hygon: Add Family 0x18 SMN access Lin Wang
2026-09-21  6:05   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260921060238.E346B1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=wanglin@open-hieco.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox