From: sashiko-bot@kernel.org
To: liupeng <liupeng01@kylinos.cn>
Cc: linux-hwmon@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/nouveau: Fix memory leaks in debugfs and hwmon init error paths
Date: Tue, 22 Sep 2026 04:46:46 +0000 [thread overview]
Message-ID: <20260922044647.1545D1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260922044044.21442-1-liupeng01@kylinos.cn>
> In nouveau_debugfs_init(), if nvif_object_ctor() fails, the previously
> allocated drm->debugfs is leaked because the function returns the
> error code directly.
>
> In nouveau_hwmon_init(), if hwmon_device_register_with_info() fails,
> the allocated hwmon structure is leaked because the function returns
> the error code directly.
>
> Fix both by freeing the allocated memory and clearing the pointer on
> the error paths.
>
> Fixes: b126a200e9db ("drm/nouveau/debugfs: we need a ctrl object for debugfs")
> Fixes: b9ed919f1c8f ("drm/nouveau/drm/pm: remove everything except the hwmon interfaces to THERM")
> Cc: stable@vger.kernel.org
> Signed-off-by: liupeng <liupeng01@kylinos.cn>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260922044044.21442-1-liupeng01@kylinos.cn?part=1
next prev parent reply other threads:[~2026-09-22 4:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 9:05 [PATCH] drm/nouveau: Fix memory leaks in debugfs and hwmon init error paths liupeng
2026-08-24 9:12 ` sashiko-bot
2026-09-17 22:10 ` lyude
2026-09-22 4:40 ` [PATCH v2] " liupeng
2026-09-22 4:46 ` sashiko-bot [this message]
2026-10-08 21:45 ` lyude
2026-10-09 11:51 ` [PATCH v3] " liupeng
2026-10-09 12:00 ` sashiko-bot
2026-10-09 21:35 ` lyude
2026-10-09 21:40 ` Danilo Krummrich
2026-10-09 21:43 ` lyude
2026-10-10 2:20 ` [PATCH v4 1/2] drm/nouveau: Fix memory leak in debugfs init error path liupeng
2026-10-10 2:20 ` [PATCH v4 2/2] drm/nouveau: Fix memory leak in hwmon " liupeng
2026-10-10 2:26 ` sashiko-bot
2026-10-10 2:26 ` [PATCH v4 1/2] drm/nouveau: Fix memory leak in debugfs " sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922044647.1545D1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=liupeng01@kylinos.cn \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox