From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f12.google.com (mail-wr2-f12.google.com [74.125.225.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D086456E067 for ; Tue, 22 Sep 2026 16:57:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790096274; cv=none; b=mZBUiXqON7tp3kyfx8ftAo3cfb6NwpnhtaLgyTucCZrby32y0hS33SGnyD80rvx1+jdGXlkTbUQLnkYvovOORxNBZ5VlsXyNoGEQlxU12FOt8UZWidPq+12zM4wSbHTWiPVh//SkgheY3ZinD+06VroZeFdRKq9gPAGRq2ZgzJo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790096274; c=relaxed/simple; bh=gQp5P6A4HKZPmr2RXt5nnsqu1turFNqjNRfQGzceh+w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gw1uZrXyYhAS5naxf0xy9+7c8tjd+IliIYOz9YliafGHn/TgtQH0ZkNAWn0wXAuBSIRtLq2OmrLAqbRGirbun/U1vgm+1ZQxPF3zpKyV/qu6WB86Mi3X8lZwP5Dujo/N280mdANo8zcthYCA93QQxMTYDSU/RZzI2tEn7bSkIRQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZABkxZUf; arc=none smtp.client-ip=74.125.225.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZABkxZUf" Received: by mail-wr2-f12.google.com with SMTP id ffacd0b85a97d-4834977ae75so118206f8f.3 for ; Tue, 22 Sep 2026 09:57:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790096270; x=1790701070; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/eycLZYI0OnWON4y4DQc42djuKTXBLKJTdaLEQ0NYzI=; b=ZABkxZUf0otGT+/5inGL3hhjZ1nWQrK0hU9ek87pyACpySKaLceOTqRKQEvfQ9IQJa Vl1WQTc4mF/d2ivT3nZsoIzlT8DAyWRM7C1w5Rfgs/io9rTSZmZNenfmUJKSm9G4XcPk gtW4S7a3qe1DKqv25xVInlKdZ7lQX0Bi9uJJkn9WS4RyBb+bWNZ3o/LPF9Kxq7zTH0TC FdPsD669QYi+pD8PfEBLKffMjPBVZBGej3TwSS6QrGsl4ATmlROiOeHVz1pD0PsLENkm 5g8si/AE/bzLFdGn67Sulg9uwoZ1dOe8+0rI6DiPQR/pcQuQ8bqbSy4VtQAHzizMlx07 mPNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790096270; x=1790701070; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=/eycLZYI0OnWON4y4DQc42djuKTXBLKJTdaLEQ0NYzI=; b=R8we/nmSJcgVfiFM6/Xvy//VKN2cWud9GsEZ/5XT5DIFHbyv8/+3Pici3YTrerkv3x lqJlshwxqT/vZMeWJZBeM74bM9aFyZK+ysAxBh0zK0onsPqC8Z3paFIcXsjjT410jJ24 kd6iybvaStIPjWCLveAlCHjN8iR6Yn4qU/XlrFbpcWo9ZgXo58N7TAUQrH67Y2StLtSI 0pHHvai9bXiVYP0yaTJdf+UHc7/j+sCsWtaHT21R4+pDiM7RHPxTw9+aw50LwTU3e1h3 AuQgoNsfQTCtMYCAhWsq4RN+xZcd5pbaBu/G8TdHk2TBG+pXwQErGf+MyAlE6DCwOidc N0Ww== X-Forwarded-Encrypted: i=1; AKwUvBwwLnTqVSSfb+LCpYYBLRwfrLEtxu/CBE3KOG07LoSawX++ctP6qjCTF46SKFYWJ3NNy1f5sgkx5QLN5g==@vger.kernel.org X-Gm-Message-State: AFuF++k9HW+oloo14ESO/FpufFkeeu7ziezLW17KOd0WeXfHE90ID7xQ yIPdVZqoHfQh7YilIOPP/Rq8f51cUxv5UtNonntnBEkAnQRAxW4fDFi4 X-Gm-Gg: AYBFou0ltaqeNBHe/Ht/yArHloMJGmR5lA2CP9vvReF8NbEnn1gVQ4SAjUOXzluu2vW tyW+yJmZJ71jL86dj1WcGEjZz/cxldL42YsNf0ZTf4UgZrPCOUqaK7G1jxH/e1R5+4SJNGIMEnD ptmjHYhJwYvgwSOumxXnAFBmZdXRNdtpXysIdELc53GHZUc0ZfsC0y4hd0JNwKIKPR9RgBi2sUf GEJGztq9+RupsWujMKKv3F1UePq23KPZUNUSEv5k0x4yawRIBrYhLW8hPrOId04FlAGz4EtCFJu U2YTW5yQpx4G/4MOWdx3QXoMTBTk+u/W1jHXcsGvvQ0K4xpr+o9vDuY3YoXG64ty1nJvlk/qiPe 97RUqvAmBNXksp1/Euw1kt2yk1gzFScYj2l56E0LRX3Y3tmW0RQRZA6l4f+jl/UNegs7S+vEFZE 3iPfJs3plaR3SJAaYhv7vyuWEu2wBiPEL40NTdPasWzaofAJGc8KfbOIuaKwn7dPexDVMgBkaqm 0Kw0nE= X-Received: by 2002:a05:600c:64c5:b0:49e:6c11:c4fc with SMTP id 5b1f17b1804b1-49fc56aa4e8mr216310585e9.7.1790096269744; Tue, 22 Sep 2026 09:57:49 -0700 (PDT) Received: from localhost.localdomain ([94.252.75.113]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49fdabe8a2asm68693625e9.4.2026.09.22.09.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 09:57:49 -0700 (PDT) From: Oleg Keri To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , "Bryan O'Donoghue" , Guenter Roeck , Bjorn Andersson , Konrad Dybcio , Abel Vesa Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org Subject: [PATCH v4 3/3] arm64: dts: qcom: glymur-lenovo-yoga-slim7x: add the embedded controller Date: Tue, 22 Sep 2026 18:57:37 +0200 Message-ID: <20260922165737.260443-4-okerixx@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260922165737.260443-1-okerixx@gmail.com> References: <20260922165737.260443-1-okerixx@gmail.com> Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Describe the Compal embedded controller on I2C at address 0x70. It provides the board thermistors, the battery cell voltages and the CPU fan speed, and drives the keyboard backlight. Its interrupt line is TLMM gpio66, falling edge, for which the file already carries a pin state. That state leaves the pin without a bias. gpio66 has no external pull and floats when the EC is not driving it, which shows up as a steady stream of spurious edges; the vendor ACPI tables describe the same pin as GpioInt(Edge, ActiveLow, Exclusive, PullUp). Enable the pull-up. Signed-off-by: Oleg Keri --- .../boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts index 769f195c99d9..bc840fd8e458 100644 --- a/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts +++ b/arch/arm64/boot/dts/qcom/glymur-lenovo-yoga-slim7x.dts @@ -659,7 +659,15 @@ &i2c9 { status = "okay"; - /* EC @ 0x70, irq = TLMM 66 */ + embedded-controller@70 { + compatible = "lenovo,yoga-slim7x-gen11-ec"; + reg = <0x70>; + + interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>; + + pinctrl-0 = <&ec_int_n_default>; + pinctrl-names = "default"; + }; }; &lpass_vamacro { @@ -990,7 +998,7 @@ reset-n-pins { ec_int_n_default: ec-int-n-state { pins = "gpio66"; function = "gpio"; - bias-disable; + bias-pull-up; }; kybd_default: kybd-default-state { base-commit: 5c4d4169604b335c38bbc79bc1fc03042981fc6f -- 2.55.0