Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Eduard Zateev" <hackerowskiy@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: pmbus: ibm-cffps: avoid format truncation warnings
Date: Wed, 23 Sep 2026 02:56:16 +0000	[thread overview]
Message-ID: <20260923025616.666261F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260923024827.56445-1-hackerowskiy@gmail.com>

> Building with W=1 reports format truncation warnings when formatting
> the firmware version values for debugfs.
> 
> The SMBus helpers return the byte and word values as int, so the
> compiler cannot infer that the formatted values fit into the small
> temporary buffers. Cast the values to u8 and u16 before formatting
> them.
> 
> This avoids the -Wformat-truncation warnings while keeping the existing
> output format unchanged.
> 
> Signed-off-by: Eduard Zateev <hackerowskiy@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923024827.56445-1-hackerowskiy@gmail.com?part=1


  reply	other threads:[~2026-09-23  2:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-23  2:48 [PATCH] hwmon: pmbus: ibm-cffps: avoid format truncation warnings Eduard Zateev
2026-09-23  2:56 ` sashiko-bot [this message]
2026-09-24 17:01 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260923025616.666261F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=hackerowskiy@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox