Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Hamza Mahfooz" <someguy@effective-light.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 1/2] hwmon: (nct6683) Report the duty cycle of NCT6687D-R system fans
Date: Sun, 04 Oct 2026 15:54:23 +0000	[thread overview]
Message-ID: <20261004155424.35E421F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20261004153250.516730-2-someguy@effective-light.com>

> Recent MSI boards (customer ID 0x20d) use an NCT6687D-R. Its system fans
> are connected to channels 10-15, which have no fan output configuration
> register, so their duty cycle is not reported.
> 
> According to a reverse engineered register map, the duty cycle of these
> channels is reported in register (0xe00 + channel - 10). Report it for the
> system fans that are present, so that pwmN matches fanN. To do so,
> support up to 16 pwm channels, indexed by fan channel.
> 
> Signed-off-by: Hamza Mahfooz <someguy@effective-light.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261004153250.516730-1-someguy@effective-light.com?part=1


  reply	other threads:[~2026-10-04 15:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-04 15:32 [PATCH 0/2] hwmon: (nct6683) Add fan control support for MSI boards with NCT6687D-R Hamza Mahfooz
2026-10-04 15:32 ` [PATCH 1/2] hwmon: (nct6683) Report the duty cycle of NCT6687D-R system fans Hamza Mahfooz
2026-10-04 15:54   ` sashiko-bot [this message]
2026-10-04 15:32 ` [PATCH 2/2] hwmon: (nct6683) Add fan control support for MSI boards with NCT6687D-R Hamza Mahfooz
2026-10-04 15:48   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261004155424.35E421F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=someguy@effective-light.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox