[PATCH 2/4] hwmon: (msi_mystic_light) Stop calling hid_hw_power()

[Guenter Roeck <linux@roeck-us.net>]

msi_ml_read_report() currently wraps hid_hw_raw_request() with
hid_hw_power(..., PM_HINT_FULLON) and hid_hw_power(..., PM_HINT_NORMAL)
to prevent USB autosuspend during the feature report transfer.

However, msi_ml_probe() already calls hid_hw_open() and keeps the HID
device open for the entire lifetime of the driver binding so its
interrupt IN endpoint remains actively polled. Because the device is
kept open and remote wakeup is not enabled on this controller, USB
autosuspend is already inhibited while the driver is bound. Consistent
with other hwmon HID drivers, explicit per-request hid_hw_power() calls
are unnecessary.

Drop the redundant hid_hw_power() calls to simplify the report read
path.

Cc: Tomasz Bojanowski <tomasz@bojanowski.me>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/hwmon/msi_mystic_light.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/hwmon/msi_mystic_light.c b/drivers/hwmon/msi_mystic_light.c
index a008999e7c06..4b4e07f15aa8 100644
--- a/drivers/hwmon/msi_mystic_light.c
+++ b/drivers/hwmon/msi_mystic_light.c
@@ -76,17 +76,9 @@ static int msi_ml_read_report(struct msi_ml_data *priv)
 	memset(buf, 0, MSI_ML_SENSOR_REPORT_SIZE);
 	buf[0] = MSI_ML_SENSOR_REPORT_ID;
 
-	/* Make sure the device is not autosuspended during the request */
-	ret = hid_hw_power(priv->hdev, PM_HINT_FULLON);
-	if (ret < 0)
-		return ret;
-
 	ret = hid_hw_raw_request(priv->hdev, MSI_ML_SENSOR_REPORT_ID, buf,
 				 MSI_ML_SENSOR_REPORT_SIZE, HID_FEATURE_REPORT,
 				 HID_REQ_GET_REPORT);
-
-	hid_hw_power(priv->hdev, PM_HINT_NORMAL);
-
 	if (ret < 0)
 		return ret;
 	if (ret != MSI_ML_SENSOR_REPORT_SIZE)
-- 
2.45.2