Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: Farouk Bouabid <farouk.bouabid@cherry.de>
To: Guenter Roeck <linux@roeck-us.net>,
	Quentin Schulz <quentin.schulz@cherry.de>,
	Jean Delvare <jdelvare@suse.com>,
	Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
	Peter Rosin <peda@axentia.se>, Heiko Stuebner <heiko@sntech.de>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v4 0/9] Add Mule MFD support
Date: Fri, 28 Jun 2024 11:03:51 +0200	[thread overview]
Message-ID: <20999754-c4c3-40f7-a9fd-88b2d3d10785@cherry.de> (raw)
In-Reply-To: <dbfa52ab-c6fa-4c11-89bd-87445941bac3@roeck-us.net>

Hi Guenter,

On 28.06.24 02:05, Guenter Roeck wrote:
> On 6/24/24 09:13, Farouk Bouabid wrote:
>> Hi Guenter,
>>
>> On 19.06.24 15:31, Guenter Roeck wrote:
>>> On 6/19/24 00:45, Farouk Bouabid wrote:


[...]


>
>> If we cannot proceed with that then we could add a compatible to the 
>> amc6821 driver to add the mux device (Basically the "tsd,mule" 
>> compatible in amc6821 compatible list would be a combo driver with 
>> mux logic + amc6821). Do you think that is more appropriate ?
>>
>
> Implement the mux as part of the amc6821 driver ? No. We could discuss
> instantiating the i2c mux driver from the amc6821 driver.


If I understand correctly we would have the amc6821 for "tsd,mule" 
compatible probe the mule-i2c-mux as platform_device. Possible DT 
representation would be something like:


i2c {
     #address-cells = <1>;
     #size-cells = <0>;

     fan@18 {
         compatible = "tsd,mule", "ti,amc6821";
         reg = <0x18>;

         i2c-mux {
             compatible = "tsd,mule-i2c-mux";
             #address-cells = <1>;
             #size-cells = <0>;

             i2c@0 {
                 reg = <0x0>;
                 #address-cells = <1>;
                 #size-cells = <0>;

                 rtc@6f {
                     compatible = "isil,isl1208";
                     reg = <0x6f>;
                 };

             };
         };
     };
};


Cheers,

Farouk


  reply	other threads:[~2024-06-28  9:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18 16:06 [PATCH v4 0/9] Add Mule MFD support Farouk Bouabid
2024-06-18 16:06 ` [PATCH v4 1/9] hwmon: (amc6821) add platform driver probe Farouk Bouabid
2024-06-18 16:06 ` [PATCH v4 2/9] hwmon: (amc6821) dev_err using amc6821 device struct Farouk Bouabid
2024-06-18 16:06 ` [PATCH v4 3/9] dt-bindings: mfd: add support for mule Farouk Bouabid
2024-06-27 20:52   ` Rob Herring
2024-06-18 16:06 ` [PATCH v4 4/9] i2c: muxes: add support for mule i2c multiplexer Farouk Bouabid
2024-06-18 16:06 ` [PATCH v4 5/9] mfd: simple-mfd-i2c: Add support for tsd,mule Farouk Bouabid
2024-06-18 16:06 ` [PATCH v4 6/9] arm64: dts: rockchip: add mule mfd (0x18) on rk3588-jaguar Farouk Bouabid
2024-06-18 16:06 ` [PATCH v4 7/9] arm64: dts: rockchip: add mule mfd (0x18) on rk3399-puma Farouk Bouabid
2024-06-18 16:06 ` [PATCH v4 8/9] arm64: dts: rockchip: add mule mfd (0x18) on rk3588-tiger Farouk Bouabid
2024-06-18 16:06 ` [PATCH v4 9/9] arm64: dts: rockchip: add mule mfd (0x18) on px30-ringneck Farouk Bouabid
2024-06-18 16:29 ` [PATCH v4 0/9] Add Mule MFD support Guenter Roeck
2024-06-18 16:51   ` Quentin Schulz
2024-06-18 17:30     ` Guenter Roeck
2024-06-19  7:45       ` Farouk Bouabid
2024-06-19 13:31         ` Guenter Roeck
2024-06-24 16:13           ` Farouk Bouabid
2024-06-28  0:05             ` Guenter Roeck
2024-06-28  9:03               ` Farouk Bouabid [this message]
2024-06-28 15:05                 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20999754-c4c3-40f7-a9fd-88b2d3d10785@cherry.de \
    --to=farouk.bouabid@cherry.de \
    --cc=andi.shyti@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=jdelvare@suse.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=peda@axentia.se \
    --cc=quentin.schulz@cherry.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox