From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Kamil Debski <kamil@wypas.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
linux-pwm@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v2 0/3] pwm: pwm-samsung: fix suspend/resume support
Date: Thu, 29 Jun 2017 13:14:09 +0200 [thread overview]
Message-ID: <2433336.l2BTX0BETK@amdc3058> (raw)
In-Reply-To: <1493028069-32003-1-git-send-email-b.zolnierkie@samsung.com>
ping. Could this patchset be merged for 4.13, please?
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
On Monday, April 24, 2017 12:01:06 PM Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> This patchset fixes suspend/resume support in pwm-samsung
> driver (which has an effect of fixing suspend/resume support
> for PWM client drivers such as pwm-fan one). Then it removes
> no longer needed suspend/resume code from pwm-fan driver.
>
> It was tested on Odroid-XU3 board (with few extra patches
> adding SoC/board suspend/resume support which are not in
> upstream yet).
>
> The initial issue that has been observed on this configuration
> was that after suspend/resume operation the fan was turned on
> (while the thermal code had explicitly disabled the fan by
> calling back into pwm-fan driver before the suspend/resume).
>
> Fixing this in the pwm-fan driver itself is not feasible since
> pwm_config()/pwm_disable() & co. API saves information about
> current state and doesn't pass the relevant values to PWM core
> if they are identical to the ones used previously (moreover PWM
> core itself does the same before calling into the PWM hardware
> driver).
>
> Changes since v1
> (https://www.spinics.net/lists/kernel/msg2480445.html):
> - added Acked-by from Guenter to patch #3
> - fixed patch #2 to use the right variable (chip -> our_chip)
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
>
> Bartlomiej Zolnierkiewicz (3):
> pwm: pwm-samsung: remove redundant checks from pwm_samsung_config()
> pwm: pwm-samsung: fix suspend/resume support
> hwmon: pwm-fan: remove no longer needed suspend/resume code
>
> drivers/hwmon/pwm-fan.c | 32 ----------------------
> drivers/pwm/pwm-samsung.c | 70 +++++++++++++++++++++++------------------------
> 2 files changed, 35 insertions(+), 67 deletions(-)
prev parent reply other threads:[~2017-06-29 11:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170424100128epcas5p20396f75d5626a320a9eb11d89ae87ac5@epcas5p2.samsung.com>
2017-04-24 10:01 ` [PATCH v2 0/3] pwm: pwm-samsung: fix suspend/resume support Bartlomiej Zolnierkiewicz
2017-04-24 10:01 ` [PATCH v2 1/3] pwm: pwm-samsung: remove redundant checks from pwm_samsung_config() Bartlomiej Zolnierkiewicz
2017-08-21 8:32 ` Thierry Reding
2017-04-24 10:01 ` [PATCH v2 2/3] pwm: pwm-samsung: fix suspend/resume support Bartlomiej Zolnierkiewicz
2017-08-21 8:34 ` Thierry Reding
2017-04-24 10:01 ` [PATCH v2 3/3] hwmon: pwm-fan: remove no longer needed suspend/resume code Bartlomiej Zolnierkiewicz
2017-06-29 11:14 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2433336.l2BTX0BETK@amdc3058 \
--to=b.zolnierkie@samsung.com \
--cc=jdelvare@suse.com \
--cc=kamil@wypas.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=thierry.reding@gmail.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox