From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC945C00140 for ; Wed, 10 Aug 2022 07:43:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230476AbiHJHni (ORCPT ); Wed, 10 Aug 2022 03:43:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230384AbiHJHnh (ORCPT ); Wed, 10 Aug 2022 03:43:37 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E0C66DFB7 for ; Wed, 10 Aug 2022 00:43:36 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id v2so11456322lfi.6 for ; Wed, 10 Aug 2022 00:43:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=4Uo3ZWK2PkqauuhMI//wUmEctHGdo/pIjPS16v/DLy0=; b=VsR7QQ+QVl+fX96n/HiH0wVDzNeE/WujLyYrlwS1BUaKKAtXTn39Y/yX5Jvr0xQwBr hgSx7b9UUY9CgTJn2HLMQkSj3kKrtFIKhTylXbGKe21axbHXA9+Twz5kcDcEsDqmvIMO rlw2XvctfsD+OdXlSeTx8TTPOFzPDdFUzArtLxb5k5d9S1m3pGpJ/PyfL3uBHtLSOBgk +LP1d9yjOEL8kpceYEfO5dmCXrAKZWM6GLbApJTToj4MxGYteyxcaXFo6aSNzpH7ZbhL Gbytzdm46sAP39As6HGxp/6tmDxeVC30B3AnrxM+BR7EuKINP9sI5WcIJZcssAZG7m7y fXyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=4Uo3ZWK2PkqauuhMI//wUmEctHGdo/pIjPS16v/DLy0=; b=TmsrQ8zvt2sJ2aFNCxmnGNlXozXG+qDl3T/IgZLxuecxmTV5qJdMdk3sRCzC714VjN C3cuwrxHTQ0DbC4x57TkLl1/JUYiUQf7lRPYowDoKdYFZHksvEcI1S/bBiiXAdWjfaH3 79eLXg8fc123T5xe+fTEwxU6RNUZD4vbyp1v7xMHTcBG5dRPrWH7WT/AAVmBCmUQkDNm r0tfzgVogeeYYtSKzvqNHzBYm0v574Y3EKC18mN+zbk8lFmzod7wGxRN29LQ763KRBpx 0j7AYFE1ns4miY1uheWiJEOsiMT+GZWgjGPx9LoNqGH8Jd47a8pcbQzPvURNUoBAQBgg UzKQ== X-Gm-Message-State: ACgBeo2Xzd6mYs9wqGj4thMOTl2eO40VJDX0q1wfKErzDGWiCYrpnykO 7d7EKFiylWHw4e/+q2XC39DXbw== X-Google-Smtp-Source: AA6agR6syBfgrUlsJSc6hKtDPcOaY8F+c1yciw+joV8Nk7hcfd3tYDrltR8Qxi4yFU1zgBfg0xHe3g== X-Received: by 2002:a05:6512:e8c:b0:48a:f47a:63e3 with SMTP id bi12-20020a0565120e8c00b0048af47a63e3mr9953796lfb.325.1660117414618; Wed, 10 Aug 2022 00:43:34 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id b22-20020a056512071600b0048bd7136ef3sm237892lfs.221.2022.08.10.00.43.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Aug 2022 00:43:34 -0700 (PDT) Message-ID: <25eefb70-a7ae-876e-c05a-bd308d41053e@linaro.org> Date: Wed, 10 Aug 2022 10:43:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/3] dt-bindings: hwmon: Add IBM OCC bindings Content-Language: en-US To: Eddie James , joel@jms.id.au Cc: linux@roeck-us.net, jdelvare@suse.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-fsi@lists.ozlabs.org, devicetree@vger.kernel.org References: <20220802194656.240564-1-eajames@linux.ibm.com> <20220802194656.240564-2-eajames@linux.ibm.com> <297ddf1f-8ddc-902c-ff3d-06b9d19c6a7b@linaro.org> <59ee8c2f-3d6c-14ed-c9f8-2bbd9377a7da@linux.ibm.com> From: Krzysztof Kozlowski In-Reply-To: <59ee8c2f-3d6c-14ed-c9f8-2bbd9377a7da@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On 09/08/2022 22:42, Eddie James wrote: >>> + ibm,inactive-on-init: >>> + description: This property describes whether or not the OCC should >>> + be marked as active during device initialization. The alternative >>> + is for user space to mark the device active based on higher level >>> + communications between the BMC and the host processor. >> I find the combination property name with this description confusing. It >> sounds like init of OCC and somehow it should be inactive? I assume if >> you initialize device, it is active. Or maybe the "init" is of something >> else? What is more, non-negation is easier to understand, so rather >> "ibm,active-on-boot" (or something like that). > > > Well, the host processor initializes the OCC during it's boot, but this > document is describing a binding to be used by a service processor > talking to the OCC. So the OCC may be in any state. The init meant > driver init, but I will simply the description and change the property > to be more explicit: ibm,no-poll-on-init since that is what is actually > happening. Similar to the FSI binding for no-scan-on-init. no-scan-on-init is not a good example. It wasn't even reviewed by Rob (looking at commit). In both cases you describe driver behavior which is not appropriate for bindings. Instead you should describe the hardware characteristics/feature/bug/state which require skipping the initialization. Best regards, Krzysztof