From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B020BC433E2 for ; Wed, 15 Jul 2020 12:17:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 968A62065D for ; Wed, 15 Jul 2020 12:17:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729381AbgGOMRm (ORCPT ); Wed, 15 Jul 2020 08:17:42 -0400 Received: from ms-10.1blu.de ([178.254.4.101]:38880 "EHLO ms-10.1blu.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725924AbgGOMRm (ORCPT ); Wed, 15 Jul 2020 08:17:42 -0400 Received: from [78.43.71.214] (helo=marius.localnet) by ms-10.1blu.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jvgLy-0001r4-4U; Wed, 15 Jul 2020 14:17:38 +0200 From: Marius Zachmann To: jaap aarts , Guenter Roeck Cc: Jean Delvare , linux-hwmon@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] hwmon: add fan/pwm driver for corsair h100i platinum Date: Wed, 15 Jul 2020 14:17:37 +0200 Message-ID: <2845728.4EH8KBbfVN@marius> In-Reply-To: <20200715030740.GB164279@roeck-us.net> References: <20200714100337.48719-1-jaap.aarts1@gmail.com> <20200715030740.GB164279@roeck-us.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Con-Id: 241080 X-Con-U: 0-mail X-Originating-IP: 78.43.71.214 Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On 15.07.20 at 05:07:40 CEST, Guenter Roeck wrote > On Tue, Jul 14, 2020 at 12:03:38PM +0200, jaap aarts wrote: > > Adds fan/pwm support for H1000i platinum. > > Custom temp/fan curves are not supported, however > > the presets found in the proprietary drivers are avaiable. > > > > Signed-off-by: Jaap Aarts > > +Marius Zachmann for input. > > Questions: > - Does this really have to be a different driver or can it be merged into > the corsair-cpro driver ? > >From what I can see the protocol has quite a few differences. A merged driver would need to implement functions like e.g. set_pwm for each device seperately. Also error handling and buffer sizes would be seperate for each device. If there were more usb/hid drivers in hwmon it maybe could make sense to have an additional abstraction layer, but for now I do not see anything which could be gained by this. Greetings Marius