From: Guenter Roeck <linux@roeck-us.net>
To: Armin Wolf <W_Armin@gmx.de>
Cc: Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org
Subject: Re: i5k_amb temp_mid replacement
Date: Thu, 7 Oct 2021 12:39:43 -0700 [thread overview]
Message-ID: <29999837-1ab4-e530-1b5b-e41807537b44@roeck-us.net> (raw)
In-Reply-To: <c817fb03-a0c7-f562-5000-2c46bad58075@roeck-us.net>
On 10/7/21 12:24 PM, Guenter Roeck wrote:
> On 10/7/21 10:59 AM, Armin Wolf wrote:
>> Am 07.10.21 um 18:30 schrieb Guenter Roeck:
>>> On 10/7/21 7:20 AM, Armin Wolf wrote:
>>>> Am 02.10.21 um 16:04 schrieb Guenter Roeck:
>>>>> On Fri, Oct 01, 2021 at 12:13:53AM +0200, Armin Wolf wrote:
>>>>>> Hello,
>>>>>>
>>>>>> while trying to convert i5k_temp to the new hwmon API to resolve
>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=208693,
>>>>>> i was asking myself whether or not temp_mid could be replaced with a
>>>>>> standard sysfs attribute?
>>>>>> Since afaik temp_mid and temp_max are both temperature limits, they
>>>>>> could potentially be replaced with
>>>>>> temp_max and temp_crit.
>>>>>>
>>>>> Quite likely. Unfortunately, the chipset documentation is not available
>>>>> to the public, so it is difficult to determine what those temperatures
>>>>> actually mean.
>>>>>
>>>>> Guenter
>>>> Darrick Wong says the chipset documentation would support such a change.
>>>> However, he fears that the changed meaning of tempX_max could confuse
>>>> userspace
>>>> programs.
>>>> But i think the current not using standard attribute names will confuse
>>>> even more
>>>> programms.
>>>
>>> I still don't know what temperature limits temp_mid and temp_max actually
>>> reflect, so I still can not really comment.
>>>
>>> Guenter
>> "Intel 6400/6402 Advanced Memory Buffer" seems to document that.
>
> Ah, thanks.
>
> From the description, it should be:
>
> TEMPLO -> temp1_max
> TEMPMID -> temp1_crit
> TEMPHI -> temp1_emergency
>
Scratch that. I am misreading the document.
TEMPLO -> temp1_min
TEMPMID -> temp1_max
TEMPHI -> temp1_crit
is fine.
Guenter
prev parent reply other threads:[~2021-10-07 19:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 22:13 i5k_amb temp_mid replacement Armin Wolf
2021-10-02 14:04 ` Guenter Roeck
2021-10-07 14:20 ` Armin Wolf
2021-10-07 16:30 ` Guenter Roeck
2021-10-07 17:59 ` Armin Wolf
2021-10-07 19:24 ` Guenter Roeck
2021-10-07 19:39 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29999837-1ab4-e530-1b5b-e41807537b44@roeck-us.net \
--to=linux@roeck-us.net \
--cc=W_Armin@gmx.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox