From: Sohil Mehta <sohil.mehta@intel.com>
To: Dave Hansen <dave.hansen@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
<linux-kernel@vger.kernel.org>
Cc: Borislav Petkov <bp@alien8.de>,
Guenter Roeck <linux@roeck-us.net>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Iwona Winiarska <iwona.winiarska@intel.com>,
<linux-hwmon@vger.kernel.org>, <openbmc@lists.ozlabs.org>,
Thomas Gleixner <tglx@kernel.org>,
Tony Luck <tony.luck@intel.com>, <x86@kernel.org>
Subject: Re: [PATCH] peci: Remove dependency on x86 CPU variables
Date: Wed, 18 Feb 2026 11:43:31 -0800 [thread overview]
Message-ID: <2ff19b89-8bb1-4670-a54b-326ea05ca49b@intel.com> (raw)
In-Reply-To: <513b4954-6c41-44f1-ae54-d7408ccd999c@intel.com>
On 2/18/2026 11:36 AM, Sohil Mehta wrote:
> On 2/18/2026 11:30 AM, Dave Hansen wrote:
>
>>>> +#define PECI_INTEL_HASWELL_X 0x306C
>>>> +#define PECI_INTEL_BROADWELL_X 0x406F
>>>> +#define PECI_INTEL_BROADWELL_D 0x5066
>>>> +#define PECI_INTEL_SKYLAKE_X 0x5065
>>>> +#define PECI_INTEL_ICELAKE_X 0x606A
>>>> +#define PECI_INTEL_ICELAKE_D 0x606C
>>>> +#define PECI_INTEL_SAPPHIRERAPIDS_X 0x806F
>>>> +#define PECI_INTEL_EMERALDRAPIDS_X 0xC06F
>>>>
>>>
>>> The _D has been used in Intel official product names such as "XEON D".
>>> AFAIU, The _X notation is specific to intel-family.h. Should that be
>>> explained in the comment above?
>>>
>>> Something like:
>>>
>>> * _X - regular server parts
>>> * _D - micro server parts
>>
>> I think I just verbatim copied the intel-family.h names and added PECI_.
>> Are you seeing something different.
>>
>
> No.
>
Scratch that. I see a difference.
#define INTEL_HASWELL IFM(6, 0x3C)
#define INTEL_HASWELL_X IFM(6, 0x3F)
PECI_INTEL_HASWELL_X (0x306C) doesn't match INTEL_HASWELL_X instead you
seem to have copied INTEL_HASWELL.
next prev parent reply other threads:[~2026-02-18 19:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 17:03 [PATCH] peci: Remove dependency on x86 CPU variables Dave Hansen
2026-02-18 19:26 ` Sohil Mehta
2026-02-18 19:30 ` Dave Hansen
2026-02-18 19:36 ` Sohil Mehta
2026-02-18 19:43 ` Sohil Mehta [this message]
2026-02-18 19:46 ` Dave Hansen
2026-02-19 10:20 ` David Laight
2026-02-19 14:57 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ff19b89-8bb1-4670-a54b-326ea05ca49b@intel.com \
--to=sohil.mehta@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=iwona.winiarska@intel.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mingo@redhat.com \
--cc=openbmc@lists.ozlabs.org \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox